linux-kernel - Re: [RESEND PATCH] mux: adgs1408: simplify with spi_get_device_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f069c82cb8b5f53553738545b8e4e15b54819e35.camel@gmail.com>
Date: Fri, 02 May 2025 08:36:01 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Mircea Caprioru
	 <mircea.caprioru@...log.com>, Peter Rosin <peda@...ntia.se>, 
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] mux: adgs1408: simplify with
 spi_get_device_match_data()

On Thu, 2025-05-01 at 19:37 +0200, Krzysztof Kozlowski wrote:
> Use spi_get_device_match_data() helper to simplify a bit the driver.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> 

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

> Resending patch from almost a year ago - there was no response to pings
> either.
> 
> Is mux subsystem still alive? Shall it be marked as orphaned?
> 
> 
>  drivers/mux/adgs1408.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
> index 22ed051eb1a4..5386cfedcb06 100644
> --- a/drivers/mux/adgs1408.c
> +++ b/drivers/mux/adgs1408.c
> @@ -59,9 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
>  	s32 idle_state;
>  	int ret;
>  
> -	chip_id = (enum adgs1408_chip_id)device_get_match_data(dev);
> -	if (!chip_id)
> -		chip_id = spi_get_device_id(spi)->driver_data;
> +	chip_id = (enum adgs1408_chip_id)spi_get_device_match_data(spi);
>  
>  	mux_chip = devm_mux_chip_alloc(dev, 1, 0);
>  	if (IS_ERR(mux_chip))