linux-kernel - Re: [PATCH 16/31] io_uring/timeout: Switch to use hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23dbf9ff-8542-43d0-8bc1-2584e5f88808@gmail.com>
Date: Fri, 2 May 2025 09:50:17 +0100
From: Pavel Begunkov <asml.silence@...il.com>
To: Nam Cao <namcao@...utronix.de>,
 Anna-Maria Behnsen <anna-maria@...utronix.de>,
 Frederic Weisbecker <frederic@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Miguel Ojeda <ojeda@...nel.org>, Kees Cook <kees@...nel.org>,
 linux-kernel@...r.kernel.org, io-uring <io-uring@...r.kernel.org>
Cc: Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 16/31] io_uring/timeout: Switch to use hrtimer_setup()

On 10/28/24 07:31, Nam Cao wrote:
> There is a newly introduced hrtimer_setup() which will replace
> hrtimer_init(). This new function is similar to the old one, except that it
> also sanity-checks and initializes the timer's callback function.
> 
> Switch to use the new function.
> 
> This new function is also used to initialize the callback function in
> .prep() (the callback function depends on whether it is IORING_OP_TIMEOUT
> or IORING_OP_LINK_TIMEOUT). Thus, callback function setup in io_timeout()
> and io_queue_linked_timeout() are now redundant, therefore remove them.

Next time do the basic courtesy of CC'ing io_uring mailing list if
you're sending io_uring patches, so that people don't have to guess
months later why there is an unknown patch in the tree and where the
hell did it came from.

-- 
Pavel Begunkov