[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d96b2243-0eb8-4596-bbef-7e7f9419d1ed@freeshell.de>
Date: Fri, 2 May 2025 04:24:43 -0700
From: E Shattow <e@...eshell.de>
To: Icenowy Zheng <uwu@...nowy.me>, Emil Renner Berthing <kernel@...il.dk>,
Conor Dooley <conor@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, E Shattow <e@...eshell.de>
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-common: use macros for MMC0
pins
On 4/23/25 23:06, Icenowy Zheng wrote:
> The pin names of MMC0 pinmux is defined in the pinctrl dt binding header
> associated with starfive,jh7110-pinctrl .
>
> Include the header file and use these names instead of raw numbers for
> defining MMC0 pinmux.
>
> Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
> ---
> This is only a prettying commit. The resulting DTB files have the same
> content with or without this patch (verified by doing sha256sum on
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb).
>
> .../boot/dts/starfive/jh7110-common.dtsi | 21 ++++++++++---------
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index c2f70f5e2918f..a2c72b385a905 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -8,6 +8,7 @@
> #include "jh7110.dtsi"
> #include "jh7110-pinfunc.h"
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
>
> / {
> aliases {
> @@ -428,16 +429,16 @@ GPOEN_ENABLE,
> };
>
> mmc-pins {
> - pinmux = <PINMUX(64, 0)>,
> - <PINMUX(65, 0)>,
> - <PINMUX(66, 0)>,
> - <PINMUX(67, 0)>,
> - <PINMUX(68, 0)>,
> - <PINMUX(69, 0)>,
> - <PINMUX(70, 0)>,
> - <PINMUX(71, 0)>,
> - <PINMUX(72, 0)>,
> - <PINMUX(73, 0)>;
> + pinmux = <PINMUX(PAD_SD0_CLK, 0)>,
> + <PINMUX(PAD_SD0_CMD, 0)>,
> + <PINMUX(PAD_SD0_DATA0, 0)>,
> + <PINMUX(PAD_SD0_DATA1, 0)>,
> + <PINMUX(PAD_SD0_DATA2, 0)>,
> + <PINMUX(PAD_SD0_DATA3, 0)>,
> + <PINMUX(PAD_SD0_DATA4, 0)>,
> + <PINMUX(PAD_SD0_DATA5, 0)>,
> + <PINMUX(PAD_SD0_DATA6, 0)>,
> + <PINMUX(PAD_SD0_DATA7, 0)>;
> bias-pull-up;
> drive-strength = <12>;
> input-enable;
Ref:
https://lore.kernel.org/lkml/ZQ2PR01MB1307BD49C0A49DAD3AA76049E600A@ZQ2PR01MB1307.CHNPR01.prod.partner.outlook.cn/
"[PATCH] riscv: dts: starfive: jh7110-common: Use named definition for
mmc1 card detect"
Thanks for taking this. Read previous comments from Hal there is yet
some description in dts/upstream/src/riscv/starfive/jh7110-pinfunc.h
that needs to change / be improved on.
-E
Powered by blists - more mailing lists