linux-kernel - Re: [PATCH] irqchip/qcom-mpm: Fix crash when trying to handle non-wake GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mcg0xRvZWEP3hmWyrLF-gsfzR9DS0umE3NffqKbrRUgdQ@mail.gmail.com>
Date: Fri, 2 May 2025 13:31:04 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Shawn Guo <shawn.guo@...aro.org>, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Alexey Klimov <alexey.klimov@...aro.org>
Subject: Re: [PATCH] irqchip/qcom-mpm: Fix crash when trying to handle
 non-wake GPIOs

On Fri, May 2, 2025 at 1:22 PM Stephan Gerhold
<stephan.gerhold@...aro.org> wrote:
>
> On Qualcomm chipsets not all GPIOs are wakeup capable. Those GPIOs do not
> have a corresponding MPM pin and should not be handled inside the MPM
> driver. The IRQ domain hierarchy is always applied, so we need to
> explicitly disconnect the hierarchy for those. The pinctrl-msm driver marks
> these with GPIO_NO_WAKE_IRQ. qcom-pdc has a check for this, but
> irq-qcom-mpm is currently missing the check. This is causing crashes when
> setting up interrupts for non-wake GPIOs, e.g.
>
>  root@rb1:~# gpiomon -c gpiochip1 10
>    irq: IRQ159: trimming hierarchy from :soc@0:interrupt-controller@...0000-1
>    Unable to handle kernel paging request at virtual address ffff8000a1dc3820
>    Hardware name: Qualcomm Technologies, Inc. Robotics RB1 (DT)
>    pc : mpm_set_type+0x80/0xcc
>    lr : mpm_set_type+0x5c/0xcc
>    Call trace:
>     mpm_set_type+0x80/0xcc (P)
>     qcom_mpm_set_type+0x64/0x158
>     irq_chip_set_type_parent+0x20/0x38
>     msm_gpio_irq_set_type+0x50/0x530
>     __irq_set_trigger+0x60/0x184
>     __setup_irq+0x304/0x6bc
>     request_threaded_irq+0xc8/0x19c
>     edge_detector_setup+0x260/0x364
>     linereq_create+0x420/0x5a8
>     gpio_ioctl+0x2d4/0x6c0
>
> Fix this by copying the check for GPIO_NO_WAKE_IRQ from qcom-pdc.c, so that
> MPM is removed entirely from the hierarchy for non-wake GPIOs.
>
> Cc: stable@...r.kernel.org
> Reported-by: Alexey Klimov <alexey.klimov@...aro.org>
> Tested-by: Alexey Klimov <alexey.klimov@...aro.org>
> Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
> Signed-off-by: Stephan Gerhold <stephan.gerhold@...aro.org>
> ---

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>