linux-kernel - Re: [PATCH] dt-bindings: dma: convert text based binding to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4d91f3c-731f-44a8-8f08-1979f335b074@kernel.org>
Date: Fri, 2 May 2025 13:37:06 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charan Pedumuru <charan.pedumuru@...il.com>
Cc: Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Thierry Reding <thierry.reding@...il.com>,
 Jonathan Hunter <jonathanh@...dia.com>, dmaengine@...r.kernel.org,
 devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: convert text based binding to json
 schema

On 02/05/2025 12:27, Charan Pedumuru wrote:
>>> +    maxItems: 1
>>> +
>>> +  reset-names:
>>> +    const: dma
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>> And here the order is correct...
>>

Fix your email program, because it re-wraps or removes line breaks in
each quote. It is making conversation unnecessarily less readable.

>>> +  - interrupts
>>> +  - clocks
>> But here different. Keep the same order as in properties.
>>
>>> +  - resets
>>> +  - reset-names
>>> +  - "#dma-cells"
>>> +
>> missing allOf: to dma-controller
> 
> 
> The reason, I didn't include dma-controller is the pattern under 
> $nodename in dma-controller is not matching with the pattern present in 
> dts files.
> 
> So, I excluded it.

Then the DTS has to be changed.


Best regards,
Krzysztof