[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87v7qjxlix.fsf@kernel.org>
Date: Fri, 02 May 2025 14:08:38 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
<alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
<gary@...yguo.net>, Björn Roy Baron
<bjorn3_gh@...tonmail.com>, "Benno
Lossin" <benno.lossin@...ton.me>, "Alice Ryhl" <aliceryhl@...gle.com>,
"Masahiro Yamada" <masahiroy@...nel.org>, "Nathan Chancellor"
<nathan@...nel.org>, "Luis Chamberlain" <mcgrof@...nel.org>, "Danilo
Krummrich" <dakr@...nel.org>, "Nicolas Schier"
<nicolas.schier@...ux.dev>, "Trevor Gross" <tmgross@...ch.edu>, "Adam
Bratschi-Kaye" <ark.email@...il.com>, <rust-for-linux@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-kbuild@...r.kernel.org>, "Petr
Pavlu" <petr.pavlu@...e.com>, "Sami Tolvanen" <samitolvanen@...gle.com>,
"Daniel Gomez" <da.gomez@...sung.com>, "Simona Vetter"
<simona.vetter@...ll.ch>, "Greg KH" <gregkh@...uxfoundation.org>, "Fiona
Behrens" <me@...enk.dev>, "Daniel Almeida"
<daniel.almeida@...labora.com>, <linux-modules@...r.kernel.org>
Subject: Re: [PATCH v10 1/3] rust: str: add radix prefixed integer parsing
functions
"Miguel Ojeda" <miguel.ojeda.sandonis@...il.com> writes:
> On Thu, May 1, 2025 at 9:55 AM Andreas Hindborg <a.hindborg@...nel.org> wrote:
>>
>> +pub mod parse_int {
>> +
>> + use crate::prelude::*;
>
> Spurious newline.
>
>> + use crate::str::BStr;
>> + use core::ops::Deref;
>
>> + /// # Examples
>> + /// ```
>
> Missing newline.
>
>> + // integer. We choose u64 as sufficiently large.
>
> `u64`
>
> (These were all in the range-diff :)
Well, range-diffs do not apply, so some manual interaction was required.
And I don't have the same built-in linter in my mind as you have 😅
I will respin now.
Best regards,
Andreas Hindborg
Powered by blists - more mailing lists