linux-kernel - Re: [PATCH] platform/mellanox: MLXREG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <150c0b1b-8845-db78-39d3-388d3ca79613@linux.intel.com>
Date: Fri, 2 May 2025 15:36:58 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Randy Dunlap <rdunlap@...radead.org>
cc: LKML <linux-kernel@...r.kernel.org>, Vadim Pasternak <vadimp@...dia.com>, 
    Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] platform/mellanox: MLXREG_DPU depends on I2C

On Thu, 1 May 2025, Randy Dunlap wrote:

> WARNING: unmet direct dependencies detected for REGMAP_I2C
>   Depends on [m]: I2C [=m]
>   Selected by [y]:
>   - MLXREG_DPU [=y] && MELLANOX_PLATFORM [=y]
> 
> Without the dependency, REGMAP_I2C=y since MLXREG_DPU=y.
> Since CONFIG_I2C=m, this causes many (> 230) unmet dependency warnings.
> E.g.:
>   Selected by [m]:
>   - EEPROM_AT24 [=m] && I2C [=m] && SYSFS [=y]
>   - SERIAL_MAX310X [=m] && TTY [=y] && HAS_IOMEM [=y] && SPI_MASTER [=y] && I2C [=m]
>   - PINCTRL_AW9523 [=m] && PINCTRL [=y] && OF [=y] && I2C [=m]
>   - PINCTRL_CY8C95X0 [=m] && PINCTRL [=y] && I2C [=m]
>   - GPIO_FXL6408 [=m] && GPIOLIB [=y] && I2C [=m]
>   - GPIO_DS4520 [=m] && GPIOLIB [=y] && I2C [=m]
>   - GPIO_PCA953X [=m] && GPIOLIB [=y] && I2C [=m]
>   - IP5XXX_POWER [=m] && POWER_SUPPLY [=y] && I2C [=m]
>   - BATTERY_CW2015 [=m] && POWER_SUPPLY [=y] && I2C [=m]
>   - CHARGER_SBS [=m] && POWER_SUPPLY [=y] && I2C [=m]
> 
> Fixes: 3e75f2954116 ("platform/mellanox: mlxreg-dpu: Add initial support for Nvidia DPU")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Vadim Pasternak <vadimp@...dia.com>
> Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: platform-driver-x86@...r.kernel.org
> ---
>  drivers/platform/mellanox/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20250501.orig/drivers/platform/mellanox/Kconfig
> +++ linux-next-20250501/drivers/platform/mellanox/Kconfig
> @@ -29,6 +29,7 @@ config MLX_PLATFORM
>  
>  config MLXREG_DPU
>  	tristate "Nvidia Data Processor Unit platform driver support"
> +	depends on I2C
>  	select REGMAP_I2C
>  	help
>  	  This driver provides support for the Nvidia BF3 Data Processor Units,
> 

Thanks for the patch but the review-ilpo-next branch already has this 
fixed, just waiting for lkp to build test it until it propagates into 
for-next.

-- 
 i.