linux-kernel - Re: [PATCH next] i2c: Fix end of loop test in i2c_atr_find_mapping_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBTZXsMJK3lsiUiU@shikoro>
Date: Fri, 2 May 2025 16:40:30 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Romain Gantois <romain.gantois@...tlin.com>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Andi Shyti <andi.shyti@...nel.org>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] i2c: Fix end of loop test in
 i2c_atr_find_mapping_by_addr()

On Wed, Apr 23, 2025 at 11:21:18AM +0300, Dan Carpenter wrote:
> When the list_for_each_entry_reverse() exits without hitting a break
> then the list cursor points to invalid memory.  So this check for
> if (c2a->fixed) is checking bogus memory.  Fix it by using a "found"
> variable to track if we found what we were looking for or not.
> 
> Fixes: c3f55241882b ("i2c: Support dynamic address translation")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Applied to for-next with Tomi's description added, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)