[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1dcf5c8e-13c6-4969-90aa-a2b8d84050da@163.com>
Date: Sat, 3 May 2025 16:29:53 +0800
From: Haiyue Wang <haiyuewa@....com>
To: David Wei <dw@...idwei.uk>, netdev@...r.kernel.org
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Shuah Khan <shuah@...nel.org>, Jens Axboe <axboe@...nel.dk>,
Simon Horman <horms@...nel.org>,
"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] selftests: iou-zcrx: Clean up build warnings
for error format
On 2025/5/3 11:24, David Wei wrote:
> On 5/2/25 10:50, Haiyue Wang wrote:
>> Clean up two build warnings:
>>
>> [1]
>>
>> iou-zcrx.c: In function ‘process_recvzc’:
>> iou-zcrx.c:263:37: warning: too many arguments for format [-Wformat-
>> extra-args]
>> 263 | error(1, 0, "payload mismatch at ", i);
>> | ^~~~~~~~~~~~~~~~~~~~~~
>>
>> [2] Use "%zd" for ssize_t type as better
>>
>> iou-zcrx.c: In function ‘run_client’:
>> iou-zcrx.c:357:47: warning: format ‘%d’ expects argument of type
>> ‘int’, but argument 4 has type ‘ssize_t’ {aka ‘long int’} [-Wformat=]
>> 357 | error(1, 0, "send(): %d", sent);
>> | ~^ ~~~~
>> | | |
>> | int ssize_t
>> {aka long int}
>> | %ld
>>
>> Signed-off-by: Haiyue Wang <haiyuewa@....com>
>
>> ---
>> v2:
>> - Dont't wrap the build warning message to make scripts/
>> checkpatch.pl happy,
>> keep it as for readability.
>> - Change the format for ssize_t from "%ld" to "%zd" as Simon
>> suggested.
>> - Change the target to net-next tree.
>> v1: https://lore.kernel.org/netdev/20250502042240.17371-1-
>> haiyuewa@....com/
>
> Thanks for the cleanups. But next time please note that there is a 24h
> cooldown on respins in netdev.
Will take care next time. Thanks, David.
>
> Reviewed-by: David Wei <dw@...idwei.uk>
Powered by blists - more mailing lists