linux-kernel - Re: [PATCH v3 3/3] drivers/base : Rename register_memory_blocks_under

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60B9F7F1-42CF-402D-ADC0-4841946D5AB3@nvidia.com>
Date: Sat, 03 May 2025 09:10:44 -0400
From: Zi Yan <ziy@...dia.com>
To: Donet Tom <donettom@...ux.ibm.com>
Cc: Mike Rapoport <rppt@...nel.org>, David Hildenbrand <david@...hat.com>,
 Oscar Salvador <osalvador@...e.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Andrew Morton <akpm@...ux-foundation.org>, rafael@...nel.org,
 Danilo Krummrich <dakr@...nel.org>, Ritesh Harjani <ritesh.list@...il.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Alison Schofield <alison.schofield@...el.com>,
 Yury Norov <yury.norov@...il.com>, Dave Jiang <dave.jiang@...el.com>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] drivers/base : Rename
 register_memory_blocks_under_node() and remove context argument

On 3 May 2025, at 1:40, Donet Tom wrote:

> The function register_memory_blocks_under_node() is now only called from
> the memory hotplug path, as register_memory_blocks_under_node_early()
> handles registration during early boot. Therefore, the context argument
> used to differentiate between early boot and hotplug is no longer needed
> and was removed.
>
> Since the function is only called from the hotplug path, we renamed
> register_memory_blocks_under_node() to
> register_memory_blocks_under_node_hotplug()
>
> Signed-off-by: Donet Tom <donettom@...ux.ibm.com>
>
> ---
>
> v2->v3
>
> Removed context argument from register_memory_blocks_under_node()
> Renamed  register_memory_blocks_under_node() to
> register_memory_blocks_under_node_hotplug()
>
> v2 - https://lore.kernel.org/all/fbe1e0c7d91bf3fa9a64ff5d84b53ded1d0d5ac7.1745852397.git.donettom@linux.ibm.com/
> v1 - https://lore.kernel.org/all/50142a29010463f436dc5c4feb540e5de3bb09df.1744175097.git.donettom@linux.ibm.com/
> ---
>  drivers/base/node.c  |  5 ++---
>  include/linux/node.h | 11 +++++------
>  mm/memory_hotplug.c  |  5 ++---
>  3 files changed, 9 insertions(+), 12 deletions(-)
>

LGTM. Acked-by: Zi Yan <ziy@...dia.com>

--
Best Regards,
Yan, Zi