linux-kernel - Re: [PATCH v2 2/2] iio: accel: fxls8962af: Fix sign temperature scan element

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBYgtRyJQXGWDgHl@debian-BULLSEYE-live-builder-AMD64>
Date: Sat, 3 May 2025 10:57:09 -0300
From: Marcelo Schmitt <marcelo.schmitt1@...il.com>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iio: accel: fxls8962af: Fix sign temperature scan
 element

On 05/02, Sean Nyekjaer wrote:
> TEMP_OUT register contains the 8-bit, 2's complement temperature value.
> Let's mark the temperature scan element signed.
> 
> Fixes: a3e0b51884ee ("iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers")
> Suggested-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
> Cc: stable@...r.kernel.org
> Signed-off-by: Sean Nyekjaer <sean@...nix.com>

Sort of nitpinking but I think the commit description could be more assertive.
The main idea is that we want to make the scan element signed because the
data read from the TEMP_OUT register is in two's complement format and not
having the scan element marked as a signed number may cause it to be mishandled
and miss displayed. Nevertheless, I do think the patch is good so

Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>