linux-kernel - [PATCH v3 00/17] nfsd: observability improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org>
Date: Sat, 03 May 2025 11:11:16 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Chuck Lever <chuck.lever@...cle.com>, 
 Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, 
 Tom Talpey <tom@...pey.com>, Trond Myklebust <trondmy@...nel.org>, 
 Anna Schumaker <anna@...nel.org>, NeilBrown <neil@...wn.name>
Cc: Sargun Dillon <sargun@...gun.me>, linux-nfs@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Jeff Layton <jlayton@...nel.org>
Subject: [PATCH v3 00/17] nfsd: observability improvements

Sorry these took a while! This version moves the new tracepoints closer
to the vfs layer, into the non-version specific common vfs helpers.

I've also made separate patches that remove the dprintks. Since the new
tracepoints aren't in the same places as the old dprintk's, there could
be an argument for keeping them. I'm fine with either.

Signed-off-by: Jeff Layton <jlayton@...nel.org>
---
Changes in v3:
- move most of the tracepoints into non-version specific nfsd/vfs.c calls
- rename them with a nfsd_vfs_* prefix
- remove the dprintks in separate patches
- Link to v2: https://lore.kernel.org/r/20250409-nfsd-tracepoints-v2-0-cf4e084fdd9c@kernel.org

Changes in v2:
- Break tracepoints out into multiple patches
- Flesh out the tracepoints in these locations to display the same info
  as legacy dprintks.
- have all the tracepoints SVC_XPRT_ENDPOINT_* info
- update svc_xprt_dequeue tracepoint to show how long xprt was on queue
- Link to v1: https://lore.kernel.org/r/20250306-nfsd-tracepoints-v1-0-4405bf41b95f@kernel.org

---
Jeff Layton (17):
      sunrpc: move the SVC_RQST_EVENT_*() macros to common header
      nfsd: add a tracepoint for nfsd_setattr
      nfsd: add a tracepoint to nfsd_lookup_dentry
      nfsd: add nfsd_vfs_create tracepoints
      nfsd: add tracepoint to nfsd_symlink
      nfsd: add tracepoint to nfsd_link()
      nfsd: add tracepoints for unlink events
      nfsd: add tracepoint to nfsd_rename
      nfsd: add tracepoint to nfsd_readdir
      nfsd: add tracepoint for getattr and statfs events
      nfsd: remove old v2/3 create path dprintks
      nfsd: remove old v2/3 SYMLINK dprintks
      nfsd: remove old LINK dprintks
      nfsd: remove REMOVE/RMDIR dprintks
      nfsd: remove dprintks for v2/3 RENAME events
      nfsd: remove legacy READDIR dprintks
      nfsd: remove legacy dprintks from GETATTR and STATFS codepaths

 fs/nfsd/nfs3proc.c            |  63 +-----------
 fs/nfsd/nfs4proc.c            |   2 +
 fs/nfsd/nfsproc.c             |  35 +------
 fs/nfsd/trace.h               | 218 ++++++++++++++++++++++++++++++++++++++++++
 fs/nfsd/vfs.c                 |  18 +++-
 include/trace/events/sunrpc.h |  23 -----
 include/trace/misc/fs.h       |  21 ++++
 include/trace/misc/sunrpc.h   |  23 +++++
 8 files changed, 287 insertions(+), 116 deletions(-)
---
base-commit: d417fc0a03710ea5ed4c50d8eff3cf29cd86c87f
change-id: 20250303-nfsd-tracepoints-c82add9155a6

Best regards,
-- 
Jeff Layton <jlayton@...nel.org>