linux-kernel - Re: [PATCH] usr/include: openrisc: don't HDRTEST bpf_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21182762-30b9-49e5-aa6c-a0f967d81529@infradead.org>
Date: Sat, 3 May 2025 16:23:13 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kernel@...r.kernel.org, Jonas Bonn <jonas@...thpole.se>,
 Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
 Stafford Horne <shorne@...il.com>, linux-openrisc@...r.kernel.org,
 linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] usr/include: openrisc: don't HDRTEST bpf_perf_event.h



On 5/3/25 9:13 AM, Masahiro Yamada wrote:
> On Sun, May 4, 2025 at 1:01 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>>
>> On Sat, Apr 26, 2025 at 12:08 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>>>
>>> Since openrisc does not support PERF_EVENTS, omit the HDRTEST of
>>> bpf_perf_event.h for arch/openrisc/.
>>>
>>> Fixes a build error:
>>> usr/include/linux/bpf_perf_event.h:14:28: error: field 'regs' has incomplete type
>>
>>
>>
>> Where can I get openrisc compiler that enables CONFIG_CC_CAN_LINK?
> 
> Never mind.
> I downloaded a one from
> https://github.com/stffrdhrn/or1k-toolchain-build/releases
> 
> Hmm, I did not observe an error like that.
> 
> Instead, I got a different error message.
> 
>   HDRTEST usr/include/linux/bpf_perf_event.h
> In file included from <command-line>:
> ./usr/include/linux/bpf_perf_event.h:15:9: error: unknown type name '__u64'
>    15 |         __u64 sample_period;
>       |         ^~~~~
> ./usr/include/linux/bpf_perf_event.h:16:9: error: unknown type name '__u64'
>    16 |         __u64 addr;
>       |         ^~~~~
> 

Does HDRTEST use the #include files from the header that is being tested?

usr/include/linux/bpf_perf_event.h #includes <asm/bpf_perf_event.h>
(from usr/include/ ??) which #includes <asm-generic/bpf_perf_event.h>
(from usr/include/ ??) which #includes <linux/ptrace.h> (from usr/include/ ??)
which #includes <linux/types.h>.  I don't see this problem in my builds.

I do still continue to see this failure:

  HDRTEST usr/include/linux/bpf_perf_event.h
In file included from <command-line>:
./usr/include/linux/bpf_perf_event.h:14:28: error: field 'regs' has incomplete type
   14 |         bpf_user_pt_regs_t regs;
      |                            ^~~~
make[5]: *** [../usr/include/Makefile:85: usr/include/linux/bpf_perf_event.hdrtest] Error 1

> 
> 
> 
> diff --git a/include/uapi/linux/bpf_perf_event.h
> b/include/uapi/linux/bpf_perf_event.h
> index eb1b9d21250c..61264bdda988 100644
> --- a/include/uapi/linux/bpf_perf_event.h
> +++ b/include/uapi/linux/bpf_perf_event.h
> @@ -8,6 +8,7 @@
>  #ifndef _UAPI__LINUX_BPF_PERF_EVENT_H__
>  #define _UAPI__LINUX_BPF_PERF_EVENT_H__
> 
> +#include <linux/types.h>
>  #include <asm/bpf_perf_event.h>
> 
>  struct bpf_perf_event_data {
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>>
>>
>>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>>> Cc: Masahiro Yamada <masahiroy@...nel.org>
>>> Cc: Jonas Bonn <jonas@...thpole.se>
>>> Cc: Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>
>>> Cc: Stafford Horne <shorne@...il.com>
>>> Cc: linux-openrisc@...r.kernel.org
>>> Cc: linux-kbuild@...r.kernel.org
>>> ---
>>>  usr/include/Makefile |    4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> --- linux-next-20250424.orig/usr/include/Makefile
>>> +++ linux-next-20250424/usr/include/Makefile
>>> @@ -59,6 +59,10 @@ ifeq ($(SRCARCH),arc)
>>>  no-header-test += linux/bpf_perf_event.h
>>>  endif
>>>
>>> +ifeq ($(SRCARCH),openrisc)
>>> +no-header-test += linux/bpf_perf_event.h
>>> +endif
>>> +
>>>  ifeq ($(SRCARCH),powerpc)
>>>  no-header-test += linux/bpf_perf_event.h
>>>  endif
>>
>>
>>
>> --
>> Best Regards
>> Masahiro Yamada
> 
> 
> 

-- 
~Randy