linux-kernel - Re: [PATCH v5 3/7] drm/msm: a6x: Rework qmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e070cce2-5037-4c22-af4e-5783bfaa51c5@quicinc.com>
Date: Sat, 3 May 2025 12:29:34 +0530
From: Akhil P Oommen <quic_akhilpo@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        "Konrad
 Dybcio" <konradybcio@...nel.org>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Viresh Kumar
	<vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd
	<sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Maya Matuszczyk <maccraft123mc@...il.com>,
        "Anthony
 Ruhier" <aruhier@...lbox.org>,
        Dmitry Baryshkov <lumag@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <freedreno@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v5 3/7] drm/msm: a6x: Rework qmp_get() error handling

On 4/23/2025 6:58 PM, Dmitry Baryshkov wrote:
> On Sat, Apr 19, 2025 at 08:21:32PM +0530, Akhil P Oommen wrote:
>> Fix the following for qmp_get() errors:
>>
>> 1. Correctly handle probe defer for A6x GPUs
>> 2. Ignore other errors because those are okay when GPU ACD is
>> not required. They are checked again during gpu acd probe.
>>
>> Signed-off-by: Akhil P Oommen <quic_akhilpo@...cinc.com>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>> Tested-by: Maya Matuszczyk <maccraft123mc@...il.com>
>> Tested-by: Anthony Ruhier <aruhier@...lbox.org>
>> ---
>>  drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> If this a fix for the existing commit, it should come first and have a
> proper Fixes: tag. If not, please squash it into the first patch.

This patch is dependent on the ACD support patch, so we can't reorder it
(mentioned in the added comment below). No Fixes tag because qmp
messaging was unused until now, so there is no point in backports. I
prefer to keep this patch separate because this looks logically separate
to me and we are changing the behavior for a6x gpu probe (removed
adreno_is_a7xx() check).

-Akhil

> 
>>
>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>> index 6bd6d7c67f98b38cb1d23f926b5e6ccbd7f2ec53..48b4ca8894ba38176481b62b7fd1406472369df1 100644
>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>> @@ -2043,9 +2043,10 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
>>  		goto detach_cxpd;
>>  	}
>>  
>> +	/* Other errors are handled during GPU ACD probe */
>>  	gmu->qmp = qmp_get(gmu->dev);
>> -	if (IS_ERR(gmu->qmp) && adreno_is_a7xx(adreno_gpu)) {
>> -		ret = PTR_ERR(gmu->qmp);
>> +	if (PTR_ERR_OR_ZERO(gmu->qmp) == -EPROBE_DEFER) {
>> +		ret = -EPROBE_DEFER;
>>  		goto detach_gxpd;
>>  	}
>>  
>>
>> -- 
>> 2.48.1
>>
>