linux-kernel - Re: [PATCH v7 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f01a9a4-89b2-4bfc-97cd-827be989ef16@kernel.org>
Date: Sun, 4 May 2025 15:40:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Friday Yang <friday.yang@...iatek.com>, Yong Wu <yong.wu@...iatek.com>,
 Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Philipp Zabel <p.zabel@...gutronix.de>
Cc: linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v7 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp
 for MT8188

On 30/04/2025 11:45, Friday Yang wrote:
> From: "Friday Yang" <friday.yang@...iatek.com>
> 
> To prevent handling glitch signals during MTCMOS on/off transitions,
> SMI requires clamp and reset operations. Parse the reset settings for
> SMI LARBs and the clamp settings for the SMI Sub-Common. Register
> genpd callback for the SMI LARBs located in image, camera and IPE
> subsystems, and apply reset and clamp operations within the callback.
> 
> Signed-off-by: Friday Yang <friday.yang@...iatek.com>
> Tested-by: Friday Yang <friday.yang@...iatek.com>

How is this possible? Are you claiming that none of other authors test
their patches? How testing would be not implied by authorship?

> Reviewed-by: Yong Wu <yong.wu@...iatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Acked-by: Rob Herring <robh@...nel.org>

Changelog says that v7 has only following changes:

  - Remove the 'devm_pm_runtime_enable' change.

While v6 had no such tags.

No clue what happened here, but looks like mess with the tags and really
incomplete changelog.

Best regards,
Krzysztof