[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250504164015.4b6f8dd1@jic23-huawei>
Date: Sun, 4 May 2025 16:40:15 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: <robh@...nel.org>, <conor+dt@...nel.org>, <linux-iio@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 09/10] iio: adc: ad4080: add driver support
On Fri, 2 May 2025 11:59:04 +0300
Antoniu Miclaus <antoniu.miclaus@...log.com> wrote:
> Add support for AD4080 high-speed, low noise, low distortion,
> 20-bit, Easy Drive, successive approximation register (SAR)
> analog-to-digital converter (ADC).
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
One trivial thing I noticed to add to Nuno's much more detailed review!
> diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
> new file mode 100644
> index 000000000000..9168dee9323e
> --- /dev/null
> +++ b/drivers/iio/adc/ad4080.c
> +static int ad4080_set_dec_rate(struct iio_dev *dev,
> + const struct iio_chan_spec *chan,
> + unsigned int mode)
> +{
> + struct ad4080_state *st = iio_priv(dev);
> + int ret;
> +
> + if ((st->filter_type >= SINC_5 && mode >= 512) || mode < 2)
> + return -EINVAL;
> +
> + ret = regmap_update_bits(st->regmap, AD4080_REG_FILTER_CONFIG,
> + AD4080_FILTER_CONFIG_SINC_DEC_RATE_MSK,
> + FIELD_PREP(AD4080_FILTER_CONFIG_SINC_DEC_RATE_MSK,
> + (ilog2(mode) - 1)));
> + if (ret)
> + return ret;
> +
> + return 0;
return regmap_update_bits();
> +}
Powered by blists - more mailing lists