linux-kernel - Re: [PATCH v3 1/2] dt-bindings: crypto: Add binding for TI DTHE V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250504-tangible-courageous-robin-3e31d1@kuoka>
Date: Sun, 4 May 2025 19:17:41 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: T Pratham <t-pratham@...com>
Cc: Herbert Xu <herbert@...dor.apana.org.au>, 
	"David S. Miller" <davem@...emloft.net>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Kamlesh Gurudasani <kamlesh@...com>, Vignesh Raghavendra <vigneshr@...com>, 
	Praneeth Bajjuri <praneeth@...com>, Manorit Chawdhry <m-chawdhry@...com>, 
	linux-crypto@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: crypto: Add binding for TI DTHE V2

On Fri, May 02, 2025 at 05:21:16PM GMT, T Pratham wrote:
> Add DT binding for Texas Instruments DTHE V2 crypto accelerator.
> 
> DTHE V2 is introduced as a part of TI AM62L SoC and can currently be
> only found in it.
> 
> Signed-off-by: T Pratham <t-pratham@...com>
> ---
>  .../devicetree/bindings/crypto/ti,dthev2.yaml | 55 +++++++++++++++++++

Filename: nothing improved.

>  MAINTAINERS                                   |  6 ++
>  2 files changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/crypto/ti,dthev2.yaml
> 
> diff --git a/Documentation/devicetree/bindings/crypto/ti,dthev2.yaml b/Documentation/devicetree/bindings/crypto/ti,dthev2.yaml
> new file mode 100644
> index 000000000000..68ed9923eebb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/ti,dthev2.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/ti,dthev2.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: K3 SoC DTHE V2 crypto module
> +
> +maintainers:
> +  - T Pratham <t-pratham@...com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,am62l-dthev2
> +
> +  reg:
> +    maxItems: 1
> +
> +  dmas:
> +    items:
> +      - description: AES Engine RX DMA Channel
> +      - description: AES Engine TX DMA Channel
> +      - description: SHA Engine TX DMA Channel
> +
> +  dma-names:
> +    items:
> +      - const: rx
> +      - const: tx1
> +      - const: tx2
> +
> +required:
> +  - compatible
> +  - reg
> +  - dmas
> +  - dma-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    cbass_main {

soc or whatever is reasonable, but follow DTS coding style.

I already asked to match coding style, although about wrapping :/

> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        crypto@...00000 {
> +          compatible = "ti,am62l-dthev2";
> +          reg = <0x00 0x40800000 0x00 0x10000>;
> +
> +          dmas = <&main_bcdma 0 0 0x4700 0>,
> +                <&main_bcdma 0 0 0xc701 0>,
> +                <&main_bcdma 0 0 0xc700 0>;

Looks misaligned, again, see DTS coding style

> +          dma-names = "rx", "tx1", "tx2";
> +        };

Best regards,
Krzysztof