linux-kernel - Re: [PATCH] memory: tegra210-emc: Support Device Tree EMC Tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALHNRZ-G5UADZznFivTTe1P2N=sNoJxA6b9Nwho9jsRh_NmLPw@mail.gmail.com>
Date: Sun, 4 May 2025 12:18:22 -0500
From: Aaron Kling <webgeek1234@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, 
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH] memory: tegra210-emc: Support Device Tree EMC Tables

On Sun, May 4, 2025 at 11:13 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 04/05/2025 17:58, Aaron Kling wrote:
> >>> +static int tegra210_emc_parse_dt(struct tegra210_emc *emc)
> >>> +{
> >>> +     struct device_node *node, *np = emc->dev->of_node;
> >>> +     int ram_code, ret = 0;
> >>> +
> >>> +     if (!np) {
> >>> +             dev_err(emc->dev, "Unable to find emc node\n");
> >>> +             return -ENODEV;
> >>> +     }
> >>> +
> >>> +     if (of_find_property(np, "nvidia,use-ram-code", NULL)) {
> >>
> >> I cannot find the bindings for this. Where is your DTS? Was it tested?
> >>
> >> It seems nothing here is documented.
> >
> > The relevant nodes are filled in by the bootloader. I had hoped that
> > the early stage bootloader would be able to copy that into the
>
> It does not matter. You cannot have compatibles and ABI here without
> documenting that ABI.

Understood, I will keep that in mind should the situation arise again.
And it will be rectified for this patch in v2.

Sincerely,
Aaron