linux-kernel - Re: [PATCH v4 1/2] rust: samples: add missing newline to pr_info! calls in rust_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72kAbB3vg60yfffviDRWgEkQsFWoLdjF2mSQszV3q-__tw@mail.gmail.com>
Date: Sun, 4 May 2025 21:48:40 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: kurti@...icto.ai
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Vincenzo Palazzo <vincenzopalazzodev@...il.com>, 
	Xiangfei Ding <dingxiangfei2009@...il.com>, Fiona Behrens <me@...enk.dev>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] rust: samples: add missing newline to pr_info!
 calls in rust_print_main

On Sun, May 4, 2025 at 5:41 PM Alban Kurti via B4 Relay
<devnull+kurti.invicto.ai@...nel.org> wrote:
>
> From: Alban Kurti <kurti@...icto.ai>
>
> Fixes: f431c5c581fa ("samples: rust: print: Add sample code for Arc printing")
> Reported-by: Miguel Ojeda <ojeda@...nel.org>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1139
> Signed-off-by: Alban Kurti <kurti@...icto.ai>

Commit messages cannot be empty, even if they may be apparently
trivial -- could you please describe the changes a bit? (i.e. "what"
and "why").

Also, I think you sent two patches with the exact same title -- I
think you did it because the Fixes tag is different, which is good.
However, you could mention the difference in the title and message?
For instance:

    rust: samples: rust_print_main: add missing newline in basic pr_info! calls
    rust: samples: rust_print_main: add missing newline in Arc<dyn>
pr_info! call

Thanks for sending these fixes!

Cheers,
Miguel