linux-kernel - Re: [PATCH] phy: freescale: fsl-samsung-hdmi: return closest rate instead LUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHCN7x+q-K067u6o=+E9ybREi_jopwhMTyMN=JKfCS4r6K=HWA@mail.gmail.com>
Date: Sun, 4 May 2025 15:44:26 -0500
From: Adam Ford <aford173@...il.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Dominique Martinet <dominique.martinet@...ark-techno.com>, Vinod Koul <vkoul@...nel.org>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Frieder Schrempf <frieder.schrempf@...tron.de>, 
	Marco Felsch <m.felsch@...gutronix.de>, Lucas Stach <l.stach@...gutronix.de>, 
	linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Makoto Sato <makoto.sato@...ark-techno.com>
Subject: Re: [PATCH] phy: freescale: fsl-samsung-hdmi: return closest rate
 instead LUT

On Mon, Mar 10, 2025 at 11:12 AM Uwe Kleine-König
<u.kleine-koenig@...libre.com> wrote:
>
> Hello Dominique,
>
> On Mon, Mar 10, 2025 at 06:48:50PM +0900, Dominique Martinet wrote:
> > [...] and I'm sure there are other improvements that could be made at
> > the edges.
>
> One thing that irritated me is the function names. `phy_clk_round_rate`
> sounds too generic. `fsl_samsung_hdmi_phy_clk_round_rate` is long, but
> I'd say would be a better match.
Uwe,

I just sent a patch to rename round_rate and set rate functions to be
more explicit.  I also tried to refactor the driver as you requested
by simplifying the code, but I didn't have time to integrate my
fractional-divder code yet.

I will be traveling for most of May, so I won't be able to revisit
this again until after May 24.  Hopefully the patches I submitted meet
your satisfaction, and I hope they address some of the concerns from
Dominique.  I also CC'd Frieder, since he's been active with this
driver as well.

adam
>
> Best regards
> Uwe