linux-kernel - Re: [PATCH v2 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b50c68bd-9b15-412a-ac00-1df25601edd9@lunn.ch>
Date: Mon, 5 May 2025 01:01:27 +0200
From: Andrew Lunn <andrew@...n.ch>
To: John Clark <inindev@...il.com>
Cc: Jonas Karlman <jonas@...boo.se>, heiko@...ech.de, robh@...nel.org,
	conor+dt@...nel.org, detlev.casanova@...labora.com,
	linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	devicetree@...r.kernel.org, krzk+dt@...nel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Board
 support

On Sun, May 04, 2025 at 05:02:33PM -0400, John Clark wrote:
> On 5/4/25 10:12 AM, Andrew Lunn wrote:
> > > > +&gmac0 {
> > > > +	clock_in_out = "output";
> > > > +	phy-handle = <&rgmii_phy0>;
> > > > +	phy-mode = "rgmii-rxid";
> > > 
> > > See Andrew's remark on v1 of this patch.
> > 
> > Hi John
> > 
> > If you have questions, please ask. It is not a good idea to silently
> > ignore reviewers comments. Either do something about it, ask
> > questions, or politely argue why the reviewer is wrong, because
> > sometimes we are.
> > 
> Hi Andrew,
> Thanks for your feedback and the link to the RGMII delays discussion. I
> assumed you suggested switching to phy-mode = "rgmii-id" from rgmii-rxid.
> The vendor’s downstream kernel uses rgmii-rxid with tx_delay = <0x20>, as
> shown in my post. I tried rgmii-id and removed tx_delay, but the interface
> failed to get a DHCP address. Reverting to rgmii-rxid with the delay
> restored functionality. Any advice on correctly configuring rgmii-id or
> adjusting delays for this board?

What PHY is it? Are you using the correct PHY driver for it, or
genphy?

rk3576-rock-4d.dts and rk3576-armsom-sige5.dts show that it is
possible to use this SoC with the correct 'rgmii-id', 

	Andrew