linux-kernel - Re: [PATCH v9 6/8] Revert "x86/mm: Remove unused __set_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250503234605.94d954b6ca70ea09c0aa8004@linux-foundation.org>
Date: Sat, 3 May 2025 23:46:05 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Coiby Xu <coxu@...hat.com>
Cc: kexec@...ts.infradead.org, Ondrej Kozina <okozina@...hat.com>, Milan
 Broz <gmazyland@...il.com>, Thomas Staudt <tstaudt@...ibm.com>, Daniel P .
 Berrangé <berrange@...hat.com>, Kairui Song
 <ryncsn@...il.com>, Pingfan Liu <kernelfans@...il.com>, Baoquan He
 <bhe@...hat.com>, Dave Young <dyoung@...hat.com>,
 linux-kernel@...r.kernel.org, x86@...nel.org, Dave Hansen
 <dave.hansen@...el.com>, Vitaly Kuznetsov <vkuznets@...hat.com>, Arnaud
 Lefebvre <arnaud.lefebvre@...ver-cloud.com>, Thomas Gleixner
 <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov
 <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin"
 <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>, Peter Zijlstra
 <peterz@...radead.org>
Subject: Re: [PATCH v9 6/8] Revert
 "x86/mm: Remove unused __set_memory_prot()"

On Fri,  2 May 2025 09:12:40 +0800 Coiby Xu <coxu@...hat.com> wrote:

> This reverts commit 693bbf2a50447353c6a47961e6a7240a823ace02 as kdump
> LUKS support (CONFIG_CRASH_DM_CRYPT) depends on __set_memory_prot.
> 

x86_64 allmodconfig:

In file included from drivers/gpu/drm/i915/gt/intel_ggtt.c:6:
./arch/x86/include/asm/set_memory.h:40:57: error: unknown type name 'pgprot_t'
   40 | int __set_memory_prot(unsigned long addr, int numpages, pgprot_t prot);
      |                                                         ^~~~~~~~

I did this:

From: Andrew Morton <akpm@...ux-foundation.org>
Subject: revert-x86-mm-remove-unused-__set_memory_prot-fix
Date: Sat May  3 11:38:32 PM PDT 2025

x86 set_memory.h needs pgtable_types.h for pgprot_t.  Obtain it via the
higher-level pgtable.h.

Cc: Baoquan He <bhe@...hat.com>
Cc: Coiby Xu <coxu@...hat.com>
Cc: "Daniel P. Berrange" <berrange@...hat.com>
Cc: Dave Hansen <dave.hansen@...el.com>
Cc: Dave Young <dyoung@...hat.com>
Cc: Jan Pazdziora <jpazdziora@...hat.com>
Cc: Liu Pingfan <kernelfans@...il.com>
Cc: Milan Broz <gmazyland@...il.com>
Cc: Ondrej Kozina <okozina@...hat.com>
Cc: Vitaly Kuznetsov <vkuznets@...hat.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 arch/x86/include/asm/set_memory.h |    1 +
 1 file changed, 1 insertion(+)

--- a/arch/x86/include/asm/set_memory.h~revert-x86-mm-remove-unused-__set_memory_prot-fix
+++ a/arch/x86/include/asm/set_memory.h
@@ -4,6 +4,7 @@

 #include <asm/page.h>
 #include <asm-generic/set_memory.h>
+#include <asm/pgtable.h>

 #define set_memory_rox set_memory_rox
 int set_memory_rox(unsigned long addr, int numpages);
_