linux-kernel - Re: [PATCH] KEYS: Invert FINAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1131866.1746344653@warthog.procyon.org.uk>
Date: Sun, 04 May 2025 08:44:13 +0100
From: David Howells <dhowells@...hat.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: dhowells@...hat.com, Jarkko Sakkinen <jarkko@...nel.org>,
    keyrings@...r.kernel.org, Lukas Wunner <lukas@...ner.de>,
    Ignat Korchagin <ignat@...udflare.com>,
    "David S.
 Miller" <davem@...emloft.net>,
    Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
    Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>,
    "Serge E. Hallyn" <serge@...lyn.com>,
    James Bottomley <James.Bottomley@...senpartnership.com>,
    Mimi Zohar <zohar@...ux.ibm.com>, linux-crypto@...r.kernel.org,
    linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
    linux-security-module@...r.kernel.org
Subject: Re: [PATCH] KEYS: Invert FINAL_PUT bit

Herbert Xu <herbert@...dor.apana.org.au> wrote:

> +	key->flags |= KEY_FLAG_DONT_GC_YET;

You need __set_bit() or 1<<N.

Also, don't really like the name, but that's just bikeshedding.  I think I'd
lean more to your initial suggestion of KEY_FLAG_ALIVE.

David