linux-kernel - Re: [PATCH v2] arm64: dts: imx8mp-var-som: Fix LDO5 shutdown causing SD card timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN3P287MB18294987F3FF8061245E62EC8B8E2@PN3P287MB1829.INDP287.PROD.OUTLOOK.COM>
Date: Mon, 5 May 2025 06:30:30 +0000
From: Tarang Raval <tarang.raval@...iconsignals.io>
To: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam
	<festevam@...il.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: imx8mp-var-som: Fix LDO5 shutdown causing
 SD card timeout

Hi Himanshu,

> Fix SD card timeout issue caused by LDO5 regulator getting disabled
> after boot.
>
> The kernel log shows LDO5 being disabled, which leads to a timeout
> on USDHC2:
> [   33.760561] LDO5: disabling
> [   81.119861] mmc1: Timeout waiting for hardware interrupt.
>
> To prevent this, set regulator-boot-on and regulator-always-on for
> LDO5. Also add the vqmmc regulator to properly support 1.8V/3.3V
> signaling for USDHC2 using a GPIO-controlled regulator.
>
> Fixes: 6c2a1f4f71258 ("arm64: dts: imx8mp-var-som-symphony: Add Variscite 
> Symphony board and VAR-SOM-MX8MP SoM")
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>

Acked-by: Tarang Raval <tarang.raval@...iconsignals.io>

Best Regards,
Tarang 

> ---
>  arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
> index b2ac2583a592..b59da91fdd04 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
> @@ -35,7 +35,6 @@ memory@...00000 {
>                        <0x1 0x00000000 0 0xc0000000>;
>          };
>  
> -
>          reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
>                  compatible = "regulator-fixed";
>                  regulator-name = "VSD_3V3";
> @@ -46,6 +45,16 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
>                  startup-delay-us = <100>;
>                  off-on-delay-us = <12000>;
>          };
> +
> +       reg_usdhc2_vqmmc: regulator-usdhc2-vqmmc {
> +               compatible = "regulator-gpio";
> +               regulator-name = "VSD_VSEL";
> +               regulator-min-microvolt = <1800000>;
> +               regulator-max-microvolt = <3300000>;
> +               gpios = <&gpio2 12 GPIO_ACTIVE_HIGH>;
> +               states = <3300000 0x0 1800000 0x1>;
> +               vin-supply = <&ldo5>;
> +       };
>  };
>  
>  &A53_0 {
> @@ -205,6 +214,7 @@ &usdhc2 {
>          pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
>          cd-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
>          vmmc-supply = <&reg_usdhc2_vmmc>;
> +       vqmmc-supply = <&reg_usdhc2_vqmmc>;
>          bus-width = <4>;
>          status = "okay";
>  };
> --
> 2.34.1