linux-kernel - Re: [PATCH next] platform/x86: oxpec: Add a lower bounds check in oxp_psy_ext_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174645311458.23202.1330515283470994332.b4-ty@linux.intel.com>
Date: Mon, 05 May 2025 16:51:54 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Antheas Kapenekakis <lkml@...heas.dev>, 
 Dan Carpenter <dan.carpenter@...aro.org>
Cc: Derek John Clark <derekjohn.clark@...il.com>, 
 Joaquín Ignacio Aramendía <samsagax@...il.com>, 
 Hans de Goede <hdegoede@...hat.com>, 
 Thomas Weißschuh <linux@...ssschuh.net>, 
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, 
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] platform/x86: oxpec: Add a lower bounds check in
 oxp_psy_ext_set_prop()

On Fri, 02 May 2025 11:40:15 +0300, Dan Carpenter wrote:

> The "val->intval" variable is an integer which comes from the user.  This
> code has an upper bounds check but the lower bounds check was
> accidentally omitted.  The write_to_ec() take a u8 value as a parameter
> so negative values would be truncated to positive values in the 0-255
> range.
> 
> Return -EINVAL if the user passes a negative value.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: oxpec: Add a lower bounds check in oxp_psy_ext_set_prop()
      commit: 55cd5e760618b3bca5b8ab63fe65ab78a753adf8

--
 i.