linux-kernel - Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBjNbVPTw4hyuKgR@smile.fi.intel.com>
Date: Mon, 5 May 2025 17:38:37 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Sakari Ailus <sakari.ailus@....fi>
Cc: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded
 of_gpio_n_cells assignment

On Mon, May 05, 2025 at 08:17:47AM +0000, Sakari Ailus wrote:
> On Thu, Apr 03, 2025 at 01:58:10PM +0300, Andy Shevchenko wrote:
> > On Thu, Apr 03, 2025 at 11:07:40AM +0300, Tomi Valkeinen wrote:
> > > On 31/03/2025 10:02, Andy Shevchenko wrote:
> > > > The default for of_gpio_n_cells is 2, no need to assign the same
> > > > in the user.
> > > 
> > > Where is this documented? I'm also having trouble finding the
> > > implementation.
> > 
> > The idea was introduced back in 391c970c0dd1 ("of/gpio: add default of_xlate
> > function if device has a node pointer"). But now I realised that it was never
> > assumed that default is 2 for the cases when the ->of_xlate() explicitly
> > provided. So, this is wrong patch, thanks for the review!
> 
> Does the same conclusion apply to the similar max96717 patch as well?

If you are referring to
20250331070152.3985520-1-andriy.shevchenko@...ux.intel.com
(and why not replying there?), then no, that change is correct.

-- 
With Best Regards,
Andy Shevchenko