linux-kernel - RE: [PATCH v2 2/9] ASoC: codec: cs42l56: Drop cs42l56.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB845926B5081C254179088BA788892@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Tue, 6 May 2025 01:13:45 +0000
From: Peng Fan <peng.fan@....com>
To: Mark Brown <broonie@...nel.org>, "Peng Fan (OSS)" <peng.fan@....nxp.com>
CC: David Rhodes <david.rhodes@...rus.com>, Richard Fitzgerald
	<rf@...nsource.cirrus.com>, Liam Girdwood <lgirdwood@...il.com>, Jaroslav
 Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Linus Walleij
	<linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Charles
 Keepax <ckeepax@...nsource.cirrus.com>, "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>, "patches@...nsource.cirrus.com"
	<patches@...nsource.cirrus.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>
Subject: RE: [PATCH v2 2/9] ASoC: codec: cs42l56: Drop cs42l56.h

> Subject: Re: [PATCH v2 2/9] ASoC: codec: cs42l56: Drop cs42l56.h
> 
> On Mon, Apr 28, 2025 at 10:09:03AM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > There is no in-tree user of "include/sound/cs42l56.h", so move 'struct
> > cs42l56_platform_data' to cs42l56.c and remove the header file.
> > And platform data is mostly for platforms that create devices non
> > using device tree. CS42L56 is a discontinued product, there is less
> > possibility that new users will use legacy method to create devices.
> > So drop cs42l56.h to prepare using GPIOD API.
> 
> This breaks an x86 allmodconfig build:
> 
> /build/stage/linux/sound/soc/codecs/cs42l56.c:26:10: fatal error:
> 'sound/cs42l56.h' file not found
>    26 | #include <sound/cs42l56.h>
>       |          ^~~~~~~~~~~~~~~~~
> 1 error generated.

Oops. This line was removed in patch 3, but it should be removed
in this patch 2.

I will fix this in V3.

Thanks,
Peng