linux-kernel - Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250505183758.7778811c@kernel.org>
Date: Mon, 5 May 2025 18:37:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, io-uring@...r.kernel.org,
 virtualization@...ts.linux.dev, kvm@...r.kernel.org,
 linux-kselftest@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Donald Hunter <donald.hunter@...il.com>,
 Jonathan Corbet <corbet@....net>, Andrew Lunn <andrew+netdev@...n.ch>,
 Jeroen de Borst <jeroendb@...gle.com>, Harshitha Ramamurthy
 <hramamurthy@...gle.com>, Kuniyuki Iwashima <kuniyu@...zon.com>, Willem de
 Bruijn <willemb@...gle.com>, Jens Axboe <axboe@...nel.dk>, Pavel Begunkov
 <asml.silence@...il.com>, David Ahern <dsahern@...nel.org>, Neal Cardwell
 <ncardwell@...gle.com>, "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang
 <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, "Eugenio
 Pérez" <eperezma@...hat.com>, Stefan Hajnoczi
 <stefanha@...hat.com>, Stefano Garzarella <sgarzare@...hat.com>, Shuah Khan
 <shuah@...nel.org>, sdf@...ichev.me, dw@...idwei.uk, Jamal Hadi Salim
 <jhs@...atatu.com>, Victor Nogueira <victor@...atatu.com>, Pedro Tammela
 <pctammela@...atatu.com>, Samiullah Khawaja <skhawaja@...gle.com>, Kaiyuan
 Zhang <kaiyuanz@...gle.com>
Subject: Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path

Functionally LGTM. But I'm not sure if the discussion with Paolo is
resolved, so here's a couple more nit picks:

On Tue, 29 Apr 2025 03:26:40 +0000 Mina Almasry wrote:
> +	case SCM_DEVMEM_DMABUF:
> +		if (cmsg->cmsg_len != CMSG_LEN(sizeof(u32)))
> +			return -EINVAL;
> +		sockc->dmabuf_id = *(u32 *)CMSG_DATA(cmsg);
> +
>  		break;

The empty line before break is very odd.

> +	sockc = (struct sockcm_cookie){ .tsflags = READ_ONCE(sk->sk_tsflags),
> +					.dmabuf_id = 0 };

Too ugly to exist, either full init fits on a line or there needs to be
a line break after {.