linux-kernel - Re: [PATCH AUTOSEL 6.14 156/642] f2fs: defer readonly check vs norecovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2102fabb-bde3-4eaa-ad38-18eb79281e0b@redhat.com>
Date: Mon, 5 May 2025 20:57:48 -0500
From: Eric Sandeen <sandeen@...hat.com>
To: Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Cc: Chao Yu <chao@...nel.org>, Jaegeuk Kim <jaegeuk@...nel.org>,
 linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH AUTOSEL 6.14 156/642] f2fs: defer readonly check vs
 norecovery

This commit is in no way a bugfix and I don't see any reason to
backport it to stable kernels.

Thanks,
-Eric

On 5/5/25 5:06 PM, Sasha Levin wrote:
> From: Eric Sandeen <sandeen@...hat.com>
> 
> [ Upstream commit 9cca49875997a1a7e92800a828a62bacb0f577b9 ]
> 
> Defer the readonly-vs-norecovery check until after option parsing is done
> so that option parsing does not require an active superblock for the test.
> Add a helpful message, while we're at it.
> 
> (I think could be moved back into parsing after we switch to the new mount
> API if desired, as the fs context will have RO state available.)
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> Reviewed-by: Chao Yu <chao@...nel.org>
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  fs/f2fs/super.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index b8a0e925a4011..d3b04a589b525 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -728,10 +728,8 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
>  			set_opt(sbi, DISABLE_ROLL_FORWARD);
>  			break;
>  		case Opt_norecovery:
> -			/* this option mounts f2fs with ro */
> +			/* requires ro mount, checked in f2fs_default_check */
>  			set_opt(sbi, NORECOVERY);
> -			if (!f2fs_readonly(sb))
> -				return -EINVAL;
>  			break;
>  		case Opt_discard:
>  			if (!f2fs_hw_support_discard(sbi)) {
> @@ -1418,6 +1416,12 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
>  		f2fs_err(sbi, "Allow to mount readonly mode only");
>  		return -EROFS;
>  	}
> +
> +	if (test_opt(sbi, NORECOVERY) && !f2fs_readonly(sbi->sb)) {
> +		f2fs_err(sbi, "norecovery requires readonly mount");
> +		return -EINVAL;
> +	}
> +
>  	return 0;
>  }
>