linux-kernel - Re: [PATCH] scsi: qla2xxx: Remove duplicate struct crb_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174649624839.3806817.14961647654388408228.b4-ty@oracle.com>
Date: Tue,  6 May 2025 00:25:21 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Nilesh Javali <njavali@...vell.com>, Kees Cook <kees@...nel.org>
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: Remove duplicate struct crb_addr_pair

On Fri, 25 Apr 2025 23:19:52 -0700, Kees Cook wrote:

> In preparation for making the kmalloc family of allocators type aware,
> we need to make sure that the returned type from the allocation matches
> the type of the variable being assigned. (Before, the allocator would
> always return "void *", which can be implicitly cast to any pointer type.)
> 
> The assigned type is "struct crb_addr_pair *" and the returned type will
> be a _different_ "struct crb_addr_pair *", causing a warning. This really
> stumped me for a bit. :) Drop the redundant declaration.
> 
> [...]

Applied to 6.16/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Remove duplicate struct crb_addr_pair
      https://git.kernel.org/mkp/scsi/c/386e014202f8

-- 
Martin K. Petersen	Oracle Linux Engineering