linux-kernel - Re: [PATCH] dt-bindings: timer: Convert csky,mptimer to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJF2gTQO-EP6ht=jh5aLrMSy8YUddgXzbN2n4JO5YhSBnPRPmA@mail.gmail.com>
Date: Tue, 6 May 2025 13:43:21 +0800
From: Guo Ren <guoren@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Flavio Suligoi <f.suligoi@...m.it>, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-csky@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: timer: Convert csky,mptimer to DT schema

Acked-by: Guo Ren <guoren@...nel.org>

On Tue, May 6, 2025 at 10:22 AM Rob Herring (Arm) <robh@...nel.org> wrote:
>
> Convert the C-SKY Multi-processor timer binding to DT schema format.
> It's a straight-forward conversion.
>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  .../bindings/timer/csky,mptimer.txt           | 42 -----------------
>  .../bindings/timer/csky,mptimer.yaml          | 46 +++++++++++++++++++
>  2 files changed, 46 insertions(+), 42 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/timer/csky,mptimer.txt
>  create mode 100644 Documentation/devicetree/bindings/timer/csky,mptimer.yaml
>
> diff --git a/Documentation/devicetree/bindings/timer/csky,mptimer.txt b/Documentation/devicetree/bindings/timer/csky,mptimer.txt
> deleted file mode 100644
> index f5c7e99cf52b..000000000000
> --- a/Documentation/devicetree/bindings/timer/csky,mptimer.txt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -============================
> -C-SKY Multi-processors Timer
> -============================
> -
> -C-SKY multi-processors timer is designed for C-SKY SMP system and the
> -regs is accessed by cpu co-processor 4 registers with mtcr/mfcr.
> -
> - - PTIM_CTLR "cr<0, 14>" Control reg to start reset timer.
> - - PTIM_TSR  "cr<1, 14>" Interrupt cleanup status reg.
> - - PTIM_CCVR "cr<3, 14>" Current counter value reg.
> - - PTIM_LVR  "cr<6, 14>" Window value reg to trigger next event.
> -
> -==============================
> -timer node bindings definition
> -==============================
> -
> -       Description: Describes SMP timer
> -
> -       PROPERTIES
> -
> -       - compatible
> -               Usage: required
> -               Value type: <string>
> -               Definition: must be "csky,mptimer"
> -       - clocks
> -               Usage: required
> -               Value type: <node>
> -               Definition: must be input clk node
> -       - interrupts
> -               Usage: required
> -               Value type: <u32>
> -               Definition: must be timer irq num defined by soc
> -
> -Examples:
> ----------
> -
> -       timer: timer {
> -               compatible = "csky,mptimer";
> -               clocks = <&dummy_apb_clk>;
> -               interrupts = <16>;
> -               interrupt-parent = <&intc>;
> -       };
> diff --git a/Documentation/devicetree/bindings/timer/csky,mptimer.yaml b/Documentation/devicetree/bindings/timer/csky,mptimer.yaml
> new file mode 100644
> index 000000000000..12cc5282c8f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/csky,mptimer.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/csky,mptimer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: C-SKY Multi-processors Timer
> +
> +maintainers:
> +  - Flavio Suligoi <f.suligoi@...m.it>
> +  - Guo Ren <guoren@...nel.org>
> +
> +description: |
> +  C-SKY multi-processors timer is designed for C-SKY SMP system and the regs are
> +  accessed by cpu co-processor 4 registers with mtcr/mfcr.
> +
> +   - PTIM_CTLR "cr<0, 14>" Control reg to start reset timer.
> +   - PTIM_TSR  "cr<1, 14>" Interrupt cleanup status reg.
> +   - PTIM_CCVR "cr<3, 14>" Current counter value reg.
> +   - PTIM_LVR  "cr<6, 14>" Window value reg to trigger next event.
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: csky,mptimer
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - clocks
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    timer {
> +        compatible = "csky,mptimer";
> +        clocks = <&dummy_apb_clk>;
> +        interrupts = <16>;
> +    };
> --
> 2.47.2
>


-- 
Best Regards
 Guo Ren