linux-kernel - RE: [PATCH v3 2/5] spi: spi-nxp-fspi: enable runtime pm for fspi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB949636EC30DB6362BF2B141B90892@DU0PR04MB9496.eurprd04.prod.outlook.com>
Date: Tue, 6 May 2025 06:19:37 +0000
From: Bough Chen <haibo.chen@....com>
To: Mark Brown <broonie@...nel.org>
CC: Han Xu <han.xu@....com>, Yogesh Gaur <yogeshgaur.83@...il.com>,
	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 2/5] spi: spi-nxp-fspi: enable runtime pm for fspi

> -----Original Message-----
> From: Mark Brown <broonie@...nel.org>
> Sent: 2025年5月2日 4:47
> To: Bough Chen <haibo.chen@....com>
> Cc: Han Xu <han.xu@....com>; Yogesh Gaur <yogeshgaur.83@...il.com>;
> linux-spi@...r.kernel.org; imx@...ts.linux.dev; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v3 2/5] spi: spi-nxp-fspi: enable runtime pm for fspi
> 
> On Mon, Apr 28, 2025 at 06:06:44PM +0800, Haibo Chen wrote:
> > Enable the runtime PM in fspi driver.
> > Also for system PM, On some board like i.MX8ULP-EVK board, after
> > system suspend, IOMUX module will lost power, so all the pinctrl
> > setting will lost when system resume back, need driver to save/restore
> > the pinctrl setting.
> 
> I think I would expect the pinctrl driver to deal with restoring the pin status over
> resume?  But perhaps that's not the way that API works?

Hi Mark,

I check the pinctrl driver, seems pinctrl only support to save/restore the hog pad, refer to pinctrl_force_sleep/pinctrl_force_default, for other pad which driver owned, need driver to handle, refer to pinctrl_pm_select_sleep_state/pinctrl_pm_select_default_state. 

Regards
Haibo Chen