lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dc61b9f7-bc3c-4fec-8386-0f40fa869dd6@nvidia.com>
Date: Tue, 6 May 2025 09:31:55 +0300
From: Gal Pressman <gal@...dia.com>
To: Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Cc: Jakub Kicinski <kuba@...nel.org>, Joe Damato <jdamato@...tly.com>,
 andrew@...n.ch, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 ecree.xilinx@...il.com, przemyslaw.kitszel@...el.com,
 daniel.zahka@...il.com, almasrymina@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.14 519/642] net: ethtool: prevent flow steering
 to RSS contexts which don't exist

On 06/05/2025 1:12, Sasha Levin wrote:
> From: Jakub Kicinski <kuba@...nel.org>
> 
> [ Upstream commit de7f7582dff292832fbdeaeff34e6b2ee6f9f95f ]
> 
> Since commit 42dc431f5d0e ("ethtool: rss: prevent rss ctx deletion
> when in use") we prevent removal of RSS contexts pointed to by
> existing flow rules. Core should also prevent creation of rules
> which point to RSS context which don't exist in the first place.
> 
> Reviewed-by: Joe Damato <jdamato@...tly.com>
> Link: https://patch.msgid.link/20250206235334.1425329-2-kuba@kernel.org
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

This patch caused a user-visible regression, I don't recommend taking it
to stable.

FWIW, I tried to fix it:
https://lore.kernel.org/netdev/20250225071348.509432-1-gal@nvidia.com/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ