| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPVz0n0+KodZkd=45Y4C9wncf+b0D1irUn+X1L6E42o4qq7oXg@mail.gmail.com>
Date: Tue, 6 May 2025 10:02:26 +0300
From: Svyatoslav Ryhel <clamor95@...il.com>
To: Chanwoo Choi <chanwoo@...nel.org>
Cc: MyungJoo Ham <myungjoo.ham@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] extcon: Add basic support for Maxim MAX14526 MUIC
вт, 6 трав. 2025 р. о 09:57 Chanwoo Choi <chanwoo@...nel.org> пише:
>
> Hi,
>
> On Tue, Feb 25, 2025 at 6:09 PM Svyatoslav Ryhel <clamor95@...il.com> wrote:
> >
> > The MAX14526 is designed to simplify interface requirements on
> > portable devices by multiplexing common inputs (USB, UART,
> > Microphone, Stereo Audio and Composite Video) on a single
> > micro/mini USB connector. The USB input supports Hi-Speed USB
> > and the audio/video inputs feature negative rail signal
> > operation allowing simple DC coupled accessories. These device
> > allow a single micro/mini USB port to support all the common
> > interfaces on Cellular phones and portable media players over
> > the same external lines.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
> > ---
> > drivers/extcon/Kconfig | 12 ++
> > drivers/extcon/Makefile | 1 +
> > drivers/extcon/extcon-max14526.c | 301 +++++++++++++++++++++++++++++++
> > 3 files changed, 314 insertions(+)
> > create mode 100644 drivers/extcon/extcon-max14526.c
> >
> > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> > index a6f6d467aacf..1096afc0b5bb 100644
> > --- a/drivers/extcon/Kconfig
> > +++ b/drivers/extcon/Kconfig
> > @@ -134,6 +134,18 @@ config EXTCON_MAX8997
> > Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory
> > detector and switch.
> >
> > +config EXTCON_MAX14526
> > + tristate "Maxim MAX14526 EXTCON Support"
> > + select IRQ_DOMAIN
> > + select REGMAP_I2C
> > + help
> > + If you say yes here you get support for the Maxim MAX14526
> > + MUIC device. The MAX14526 MUIC is a USB port accessory
> > + detector and switch. The MAX14526 is designed to simplify
> > + interface requirements on portable devices by multiplexing
> > + common inputs (USB, UART, Microphone, Stereo Audio and
> > + Composite Video) on a single micro/mini USB connector.
> > +
> > config EXTCON_PALMAS
> > tristate "Palmas USB EXTCON support"
> > depends on MFD_PALMAS
> > diff --git a/drivers/extcon/Makefile b/drivers/extcon/Makefile
> > index 0d6d23faf748..6482f2bfd661 100644
> > --- a/drivers/extcon/Makefile
> > +++ b/drivers/extcon/Makefile
> > @@ -18,6 +18,7 @@ obj-$(CONFIG_EXTCON_MAX3355) += extcon-max3355.o
> > obj-$(CONFIG_EXTCON_MAX77693) += extcon-max77693.o
> > obj-$(CONFIG_EXTCON_MAX77843) += extcon-max77843.o
> > obj-$(CONFIG_EXTCON_MAX8997) += extcon-max8997.o
> > +obj-$(CONFIG_EXTCON_MAX14526) += extcon-max14526.o
> > obj-$(CONFIG_EXTCON_PALMAS) += extcon-palmas.o
> > obj-$(CONFIG_EXTCON_PTN5150) += extcon-ptn5150.o
> > obj-$(CONFIG_EXTCON_QCOM_SPMI_MISC) += extcon-qcom-spmi-misc.o
> > diff --git a/drivers/extcon/extcon-max14526.c b/drivers/extcon/extcon-max14526.c
> > new file mode 100644
> > index 000000000000..b38b20a4db47
> > --- /dev/null
> > +++ b/drivers/extcon/extcon-max14526.c
> > @@ -0,0 +1,301 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +#include <linux/device.h>
> > +#include <linux/devm-helpers.h>
> > +#include <linux/delay.h>
> > +#include <linux/err.h>
> > +#include <linux/extcon-provider.h>
> > +#include <linux/i2c.h>
> > +#include <linux/mod_devicetable.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/module.h>
> > +#include <linux/pm.h>
> > +#include <linux/regmap.h>
> > +
> > +/* I2C addresses of MUIC internal registers */
> > +#define MAX14526_DEVICE_ID 0x00
> > +#define MAX14526_ID 0x02
> > +
> > +/* CONTROL_1 register masks */
> > +#define MAX14526_CONTROL_1 0x01
> > +#define ID_2P2 BIT(6)
> > +#define ID_620 BIT(5)
> > +#define ID_200 BIT(4)
> > +#define VLDO BIT(3)
> > +#define SEMREN BIT(2)
> > +#define ADC_EN BIT(1)
> > +#define CP_EN BIT(0)
> > +
> > +/* CONTROL_2 register masks */
> > +#define MAX14526_CONTROL_2 0x02
> > +#define INTPOL BIT(7)
> > +#define INT_EN BIT(6)
> > +#define MIC_LP BIT(5)
> > +#define CP_AUD BIT(4)
> > +#define CHG_TYPE BIT(1)
> > +#define USB_DET_DIS BIT(0)
>
> (snip)
>
> > +static int max14526_probe(struct i2c_client *client)
> > +{
> > + struct device *dev = &client->dev;
> > + struct max14526_data *priv;
> > + int ret, dev_id, rev, i;
> > +
> > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > + if (!priv)
> > + return -ENOMEM;
> > +
> > + priv->client = client;
> > + i2c_set_clientdata(client, priv);
> > +
> > + priv->regmap = devm_regmap_init_i2c(client, &max14526_regmap_config);
> > + if (IS_ERR(priv->regmap))
> > + return dev_err_probe(dev, PTR_ERR(priv->regmap), "cannot allocate regmap\n");
> > +
> > + for (i = 0; i < MAX14526_N_REGMAP_FIELDS; i++) {
> > + priv->rfield[i] = devm_regmap_field_alloc(dev, priv->regmap,
> > + max14526_reg_field[i]);
> > + if (IS_ERR(priv->rfield[i]))
> > + return dev_err_probe(dev, PTR_ERR(priv->rfield[i]),
> > + "cannot allocate regmap field\n");
> > + }
> > +
> > + /* Detect if MUIC version is supported */
> > + ret = regmap_field_read(priv->rfield[VENDOR_ID], &dev_id);
> > + if (ret)
> > + return dev_err_probe(dev, ret, "failed to read MUIC ID\n");
> > +
> > + regmap_field_read(priv->rfield[CHIP_REV], &rev);
> > +
> > + if (dev_id == MAX14526_ID)
> > + dev_info(dev, "detected MAX14526 MUIC with id 0x%x, rev 0x%x\n", dev_id, rev);
> > + else
> > + dev_err_probe(dev, -EINVAL, "MUIC vendor id 0x%X is not recognized\n", dev_id);
> > +
> > + priv->edev = devm_extcon_dev_allocate(dev, max14526_extcon_cable);
> > + if (IS_ERR(priv->edev))
> > + return dev_err_probe(dev, (IS_ERR(priv->edev)),
> > + "failed to allocate extcon device\n");
> > +
> > + ret = devm_extcon_dev_register(dev, priv->edev);
> > + if (ret < 0)
> > + return dev_err_probe(dev, ret, "failed to register extcon device\n");
> > +
> > + ret = max14526_ap_usb_mode(priv);
> > + if (ret < 0)
> > + return dev_err_probe(dev, ret, "failed to set AP USB mode\n");
> > +
> > + regmap_write_bits(priv->regmap, MAX14526_CONTROL_2, INT_EN, INT_EN);
> > + regmap_write_bits(priv->regmap, MAX14526_CONTROL_2, USB_DET_DIS, ~USB_DET_DIS);
>
> When using ~USB_DET_DIS, there is overflow issue like you are received
> mail from linux-next.
> I'd like you to fix this issue.
>
> I'm sorry for late reply.
>
It should not matter because register bit size is 8 bit anyway.
> (snip)
>
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics
Powered by blists - more mailing lists