linux-kernel - Re: [PATCH] i2c: omap: fix deprecated of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBmz2iDObAgendMc@hovoldconsulting.com>
Date: Tue, 6 May 2025 09:01:46 +0200
From: Johan Hovold <johan@...nel.org>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Johan Hovold <johan+linaro@...nel.org>, Vignesh R <vigneshr@...com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Andreas Kemnade <andreas@...nade.info>,
	Kevin Hilman <khilman@...libre.com>,
	Roger Quadros <rogerq@...nel.org>, Tony Lindgren <tony@...mide.com>,
	Janusz Krzysztofik <jmkrzyszt@...il.com>,
	linux-omap@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jayesh Choudhary <j-choudhary@...com>
Subject: Re: [PATCH] i2c: omap: fix deprecated of_property_read_bool() use

On Tue, May 06, 2025 at 12:13:00AM +0200, Andi Shyti wrote:
> On Mon, May 05, 2025 at 12:00:07PM +0200, Johan Hovold wrote:
> > On Tue, Apr 29, 2025 at 03:10:13PM +0200, Andi Shyti wrote:

> > > I'm sorry, but as I understand it, the Fixes tag should be used
> > > only when an actual bug is being fixed. I've seen stable
> > > maintainers getting annoyed when it's used for non-bug issues.
> > 
> > You seem to confuse the Fixes tag with a CC stable tag. A Fixes tag is
> > used to indicate which commit introduced an issue, while the CC stable
> > tag is used to flag a commit for backporting (and the fact that autosel
> > tends to pick up patches with just a Fixes doesn't change this).
> 
> (the Cc tag for fixes is not mandatory, it's more a courtesy)

You should still add it as described by the stable tree docs:

	To have a patch you submit for mainline inclusion later
	automatically picked up for stable trees, add this tag in the
	sign-off area::

	Cc: stable@...r.kernel.org

The stable team also scans through patches with just a Fixes tag because
some people forget to add the tag, don't know that they should, or don't
care about stable, but you should not rely on that (as I alluded to
above).

> > It's perfectly fine to fix an issue and use a Fixes tag when doing so
> > even if the fix itself does not qualify for backporting (for whatever
> > reason).
> 
> Oh yes, I forgot that patch was part of the 6.15 merge window. I
> will then move it to the -fixes and send it for this week's merge
> request.

Perfect, thanks.

Johan