linux-kernel - Re: [PATCH v1 1/1] media: i2c: max96717: Drop unused field assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ebde0bfaa1f42a78dbd3e66eb92fc74bcfe7f7cc.camel@collabora.com>
Date: Tue, 06 May 2025 09:23:47 +0200
From: Julien Massot <julien.massot@...labora.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Hans Verkuil
	 <hverkuil@...all.nl>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: max96717: Drop unused field
 assignment

Hi,

Sorry for the delay.

On Mon, 2025-03-31 at 10:01 +0300, Andy Shevchenko wrote:
> The driver is not using gpio_chip::of_xlate() callback and hence
> the of_gpio_n_cells assignment is unused. Drop it.
> 
> With that done, remove unneeded OF dependency and extend compile
> test coverage.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/media/i2c/Kconfig    | 2 +-
>  drivers/media/i2c/max96717.c | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index e45ba127069f..8889f154f22e 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -1641,7 +1641,7 @@ config VIDEO_MAX96714
>  
>  config VIDEO_MAX96717
>  	tristate "Maxim MAX96717 GMSL2 Serializer support"
> -	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
> +	depends on I2C && VIDEO_DEV && COMMON_CLK
>  	select I2C_MUX
>  	select MEDIA_CONTROLLER
>  	select GPIOLIB
> diff --git a/drivers/media/i2c/max96717.c b/drivers/media/i2c/max96717.c
> index 9259d58ba734..30c5ca0e817a 100644
> --- a/drivers/media/i2c/max96717.c
> +++ b/drivers/media/i2c/max96717.c
> @@ -357,7 +357,6 @@ static int max96717_gpiochip_probe(struct max96717_priv *priv)
>  	gc->direction_output = max96717_gpio_direction_out;
>  	gc->set = max96717_gpiochip_set;
>  	gc->get = max96717_gpiochip_get;
> -	gc->of_gpio_n_cells = 2;
>  
>  	/* Disable GPIO forwarding */
>  	for (i = 0; i < gc->ngpio; i++)

Reviewed-by: Julien Massot <julien.massot@...labora.com>

Regards,
Julien