linux-kernel - Re: [PATCH v11 02/16] xfs: only call xfs_setsize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85a09b43-bcc8-4f0d-b919-cfc7d412b856@oracle.com>
Date: Tue, 6 May 2025 07:57:54 +0100
From: John Garry <john.g.garry@...cle.com>
To: Christoph Hellwig <hch@....de>
Cc: "Darrick J. Wong" <djwong@...nel.org>, brauner@...nel.org,
        viro@...iv.linux.org.uk, jack@...e.cz, cem@...nel.org,
        linux-fsdevel@...r.kernel.org, dchinner@...hat.com,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        ojaswin@...ux.ibm.com, ritesh.list@...il.com,
        martin.petersen@...cle.com, linux-ext4@...r.kernel.org,
        linux-block@...r.kernel.org, catherine.hoang@...cle.com,
        linux-api@...r.kernel.org
Subject: Re: [PATCH v11 02/16] xfs: only call xfs_setsize_buftarg once per
 buffer target

On 06/05/2025 05:22, Christoph Hellwig wrote:
>>> It seems simpler to just have the individual sync_blockdev() calls from
>>> xfs_alloc_buftarg(), rather than adding ERR_PTR() et al handling in both
>>> xfs_alloc_buftarg() and xfs_open_devices().
>> Which of the following is better:
> To me version 2 looks much better.  I had initial reservations as
> ERR_PTR doesn't play well with userspace, but none of this code is
> in libxfs, so that should be fine.

cool, that is what we/I had gone with in prep'ing v12