linux-kernel - Re: [PATCH v2] tools/sched_ext: Fix errors when running make mrproper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBm8ksy5IQAbhga1@gpd3>
Date: Tue, 6 May 2025 09:38:58 +0200
From: Andrea Righi <arighi@...dia.com>
To: Bing Huang <huangbing@...inos.cn>
Cc: tj@...nel.org, void@...ifault.com, changwoo@...lia.com,
	joshdon@...gle.com, brho@...gle.com, haoluo@...gle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tools/sched_ext: Fix errors when running make mrproper

On Tue, May 06, 2025 at 03:34:32PM +0800, Bing Huang wrote:
> If the system environment used to compile the kernel code does not
> have the BTF feature enabled, running make mrproper will result in
> errors similar to the following:
> 
> Makefile:84: *** Cannot find a vmlinux for VMLINUX_BTF at any of "  ../../vmlinux /sys/kernel/btf/vmlinux /boot/vmlinux-4.4.131-20190505.kylin.server-generic".  Stop.
> make[2]: *** [Makefile:192: sched_ext_clean] Error 2
> make[1]: *** [/home/huangbing/klinux/Makefile:1374: sched_ext] Error 2
> make: *** [Makefile:236: __sub-make] Error 2
> 
> Signed-off-by: Bing Huang <huangbing@...inos.cn>
> Signed-off-by: Andrea Righi <arighi@...dia.com>

You can just add Suggested-by here, no need to add my SoB line. Apart than
that, looks good to me.

Reviewed-by: Andrea Righi <arighi@...dia.com>

Thanks,
-Andrea

> ---
> 
> v1->v2: Sort MAKECMDGOALS and check for clean target
> 
>  tools/sched_ext/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/sched_ext/Makefile b/tools/sched_ext/Makefile
> index ca3815e572d8..212717aa78af 100644
> --- a/tools/sched_ext/Makefile
> +++ b/tools/sched_ext/Makefile
> @@ -79,9 +79,11 @@ VMLINUX_BTF_PATHS ?= $(if $(O),$(O)/vmlinux)					\
>  		     /sys/kernel/btf/vmlinux					\
>  		     /boot/vmlinux-$(shell uname -r)
>  VMLINUX_BTF ?= $(abspath $(firstword $(wildcard $(VMLINUX_BTF_PATHS))))
> +ifneq ($(sort $(MAKECMDGOALS)),clean)
>  ifeq ($(VMLINUX_BTF),)
>  $(error Cannot find a vmlinux for VMLINUX_BTF at any of "$(VMLINUX_BTF_PATHS)")
>  endif
> +endif
>  
>  BPFTOOL ?= $(DEFAULT_BPFTOOL)
>  
> -- 
> 2.25.1
>