linux-kernel - Re: [PATCH v4 5/9] gpio: Add new gpio-macsmc driver for Apple Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MebFf-DBh_=H0J4ORStaxBYhOnfY+jSk2d4UpdyS=m1LA@mail.gmail.com>
Date: Tue, 6 May 2025 10:07:00 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: sven@...npeter.dev
Cc: Janne Grunau <j@...nau.net>, Alyssa Rosenzweig <alyssa@...enzweig.io>, Neal Gompa <neal@...pa.dev>, 
	Hector Martin <marcan@...can.st>, Linus Walleij <linus.walleij@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Sebastian Reichel <sre@...nel.org>, Lee Jones <lee@...nel.org>, Marc Zyngier <maz@...nel.org>, 
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, asahi@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org
Subject: Re: [PATCH v4 5/9] gpio: Add new gpio-macsmc driver for Apple Macs

On Sat, May 3, 2025 at 12:07 PM Sven Peter via B4 Relay
<devnull+sven.svenpeter.dev@...nel.org> wrote:
>
> From: Hector Martin <marcan@...can.st>
>
> This driver implements the GPIO service on top of the SMC framework
> on Apple Mac machines. In particular, these are the GPIOs present in the
> PMU IC which are used to control power to certain on-board devices.
>
> Although the underlying hardware supports various pin config settings
> (input/output, open drain, etc.), this driver does not implement that
> functionality and leaves it up to the firmware to configure things
> properly. We also don't yet support interrupts/events. This is
> sufficient for device power control, which is the only thing we need to
> support at this point. More features will be implemented when needed.
>
> To our knowledge, only Apple Silicon Macs implement this SMC feature.
>
> Signed-off-by: Hector Martin <marcan@...can.st>
> Reviewed-by: Bartosz Golaszewski <brgl@...ev.pl>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Reviewed-by: Sven Peter <sven@...npeter.dev>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> Signed-off-by: Sven Peter <sven@...npeter.dev>
> ---

[snip]

> +
> +       smcgp->gc.label = "macsmc-pmu-gpio";
> +       smcgp->gc.owner = THIS_MODULE;
> +       smcgp->gc.get = macsmc_gpio_get;
> +       smcgp->gc.set = macsmc_gpio_set;

I must have given my Reviewed-by under this driver before we started
the conversion to the new GPIO driver setters. Could you please
replace this with set_rv() as the old set() is now deprecated?

> +       smcgp->gc.get_direction = macsmc_gpio_get_direction;
> +       smcgp->gc.init_valid_mask = macsmc_gpio_init_valid_mask;
> +       smcgp->gc.can_sleep = true;
> +       smcgp->gc.ngpio = MAX_GPIO;
> +       smcgp->gc.base = -1;
> +       smcgp->gc.parent = &pdev->dev;
> +

Bart