linux-kernel - RE: [PATCH] RDMA/siw: Remove unused siw_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR15MB25226B69D82A496491A9BDC499892@DM6PR15MB2522.namprd15.prod.outlook.com>
Date: Tue, 6 May 2025 08:54:20 +0000
From: Bernard Metzler <BMT@...ich.ibm.com>
To: "linux@...blig.org" <linux@...blig.org>, "jgg@...pe.ca" <jgg@...pe.ca>,
        "leon@...nel.org" <leon@...nel.org>
CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE:  [PATCH] RDMA/siw: Remove unused siw_mem_add



> -----Original Message-----
> From: linux@...blig.org <linux@...blig.org>
> Sent: Monday, May 5, 2025 11:02 PM
> To: Bernard Metzler <BMT@...ich.ibm.com>; jgg@...pe.ca; leon@...nel.org
> Cc: linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org; Dr. David
> Alan Gilbert <linux@...blig.org>
> Subject: [EXTERNAL] [PATCH] RDMA/siw: Remove unused siw_mem_add
> 
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> siw_mem_add() was added in 2019 by
> commit 2251334dcac9 ("rdma/siw: application buffer management")
> but has remained unused.
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>  drivers/infiniband/sw/siw/siw_mem.c | 24 ------------------------
>  drivers/infiniband/sw/siw/siw_mem.h |  1 -
>  2 files changed, 25 deletions(-)
> 
> diff --git a/drivers/infiniband/sw/siw/siw_mem.c
> b/drivers/infiniband/sw/siw/siw_mem.c
> index dcb963607c8b..ac943474d797 100644
> --- a/drivers/infiniband/sw/siw/siw_mem.c
> +++ b/drivers/infiniband/sw/siw/siw_mem.c
> @@ -17,30 +17,6 @@
>  /* Stag lookup is based on its index part only (24 bits). */
>  #define SIW_STAG_MAX_INDEX	0x00ffffff
> 
> -/*
> - * The code avoids special Stag of zero and tries to randomize
> - * STag values between 1 and SIW_STAG_MAX_INDEX.
> - */
> -int siw_mem_add(struct siw_device *sdev, struct siw_mem *m)
> -{
> -	struct xa_limit limit = XA_LIMIT(1, SIW_STAG_MAX_INDEX);
> -	u32 id, next;
> -
> -	get_random_bytes(&next, 4);
> -	next &= SIW_STAG_MAX_INDEX;
> -
> -	if (xa_alloc_cyclic(&sdev->mem_xa, &id, m, limit, &next,
> -	    GFP_KERNEL) < 0)
> -		return -ENOMEM;
> -
> -	/* Set the STag index part */
> -	m->stag = id << 8;
> -
> -	siw_dbg_mem(m, "new MEM object\n");
> -
> -	return 0;
> -}
> -
>  /*
>   * siw_mem_id2obj()
>   *
> diff --git a/drivers/infiniband/sw/siw/siw_mem.h
> b/drivers/infiniband/sw/siw/siw_mem.h
> index e74cfcd6dbc1..8e769d30e2ac 100644
> --- a/drivers/infiniband/sw/siw/siw_mem.h
> +++ b/drivers/infiniband/sw/siw/siw_mem.h
> @@ -12,7 +12,6 @@ void siw_umem_release(struct siw_umem *umem);
>  struct siw_pbl *siw_pbl_alloc(u32 num_buf);
>  dma_addr_t siw_pbl_get_buffer(struct siw_pbl *pbl, u64 off, int *len, int
> *idx);
>  struct siw_mem *siw_mem_id2obj(struct siw_device *sdev, int stag_index);
> -int siw_mem_add(struct siw_device *sdev, struct siw_mem *m);
>  int siw_invalidate_stag(struct ib_pd *pd, u32 stag);
>  int siw_check_mem(struct ib_pd *pd, struct siw_mem *mem, u64 addr,
>  		  enum ib_access_flags perms, int len);
> --
> 2.49.0

Thanks David, good catch!

Acked-by: Bernard Metzler <bmt@...ich.ibm.com>