linux-kernel - Re: [PATCH v1 17/26] x86/cpuid: Remove direct CPUID(0x2) query API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBnPVj9NZlROyA0W@gmail.com>
Date: Tue, 6 May 2025 10:59:02 +0200
From: Ingo Molnar <mingo@...nel.org>
To: "Ahmed S. Darwish" <darwi@...utronix.de>
Cc: Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	John Ogness <john.ogness@...utronix.de>, x86@...nel.org,
	x86-cpuid@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 17/26] x86/cpuid: Remove direct CPUID(0x2) query API


* Ahmed S. Darwish <darwi@...utronix.de> wrote:

> All call sites at x86/cpu and x86/cacheinfo has been switched from direct
> CPUID(0x2) access to scanned CPUID access.  Remove the direct CPUID(0x2)
> query APIs at <asm/cpuid/leaf_0x2_api.h>.
> 
> Rename the iterator macro:
> 
>     for_each_scanned_leaf_0x2_entry()
> 
> back to:
> 
>     for_each_leaf_0x2_entry()
> 
> since the "for_each_scanned_.." name and was just chosen to accommodate
> the direct CPUID(0x2) to scanned CPUID(0x2) transition.
> 
> Signed-off-by: Ahmed S. Darwish <darwi@...utronix.de>
> ---
>  arch/x86/include/asm/cpuid/leaf_0x2_api.h | 72 +----------------------
>  arch/x86/kernel/cpu/cacheinfo.c           |  2 +-
>  arch/x86/kernel/cpu/intel.c               |  2 +-
>  3 files changed, 5 insertions(+), 71 deletions(-)

There's one mention of this API orphaned in the 
for_each_leaf_0x2_entry() comment section:

  arch/x86/include/asm/cpuid/leaf_0x2_api.h: *    for_each_scanned_leaf_0x2_entry(regs, ptr, entry) {

Thanks,

	Ingo