linux-kernel - Re: [PATCH v3 6/9] soc: qcom: geni-se: Add support to load QUP SE Firmware via Linux subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97cba4b6-2966-4356-888f-b7e4e091b8ee@quicinc.com>
Date: Tue, 6 May 2025 14:47:45 +0530
From: Viken Dadhaniya <quic_vdadhani@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, <andi.shyti@...nel.org>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>,
        <andersson@...nel.org>, <konradybcio@...nel.org>,
        <johan+linaro@...nel.org>, <dianders@...omium.org>,
        <agross@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-i2c@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
        <linux-spi@...r.kernel.org>, <quic_msavaliy@...cinc.com>,
        <quic_anupkulk@...cinc.com>
Subject: Re: [PATCH v3 6/9] soc: qcom: geni-se: Add support to load QUP SE
 Firmware via Linux subsystem



On 5/3/2025 10:51 PM, Dmitry Baryshkov wrote:
> On Sat, May 03, 2025 at 04:47:52PM +0530, Viken Dadhaniya wrote:
>>
>>
>> On 3/8/2025 11:36 PM, Konrad Dybcio wrote:
>>> On 3.03.2025 1:43 PM, Viken Dadhaniya wrote:
>>>> Load the firmware to QUP SE based on the 'firmware-name' property specified
>>>> in devicetree. Populate Serial engine and base address details in the probe
>>>> function of the protocol driver and pass to firmware load routine.
>>>>
>>>> Skip the firmware loading if the firmware is already loaded in Serial
>>>> Engine's firmware memory area.
>>>>
>>>> Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
>>>> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
>>>> Signed-off-by: Viken Dadhaniya <quic_vdadhani@...cinc.com>
>>>> ---
>>>
>>> [...]
>>>
>>>> +		break;
>>>> +
>>>> +	default:
>>>> +		dev_err(rsc->se->dev, "invalid se mode: %d\n", rsc->mode);
>>>> +		return -EINVAL;
>>>
>>> I wouldn't expect this to ever fail..
>>
>> Yes, that's correct. But including a default case helps handle unexpected or
>> invalid input gracefully.
>>
>> Please let me know if you would like me to remove it.
> 
> If you are asking for additional comments, please refrain from sending
> the next iteration until you actally resolve all the open questions.
> 

Sure, I will take care of it in future patches.