linux-kernel - Re: [PATCH] [v2] media: platform: cros-ec: Add Dirks to the match table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de23db31-0cef-4689-9bdb-72639e34285c@xs4all.nl>
Date: Tue, 6 May 2025 11:53:53 +0200
From: Hans Verkuil <hverkuil@...all.nl>
To: Kells Ping <kells.ping@...nta.corp-partner.google.com>,
 LKML <linux-kernel@...r.kernel.org>
Cc: groeck@...omium.org, Benson Leung <bleung@...omium.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 chrome-platform@...ts.linux.dev, linux-media@...r.kernel.org
Subject: Re: [PATCH] [v2] media: platform: cros-ec: Add Dirks to the match
 table

Hi Kells,

On 5/6/25 10:43, Kells Ping wrote:
> The Google Dirks device uses the same approach as the Google Brask
> which enables the HDMI CEC via the cros-ec-cec driver.

The v1 patch has already been merged here:

https://gitlab.freedesktop.org/linux-media/media-committers

Can you post a v3 with just the diff between v1 and v2?

Regards,

	Hans

> 
> ---
> 
> Changes in v2: update ports
> native driver cec is port 0.
> bitbang driver cec is port 1.
> 
> Signed-off-by: Kells Ping <kells.ping@...nta.corp-partner.google.com>
> ---
>  drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> index 12b73ea0f31d..81b4524c69f4 100644
> --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> @@ -298,6 +298,7 @@ struct cec_dmi_match {
>  static const char *const port_b_conns[] = { "Port B", NULL };
>  static const char *const port_db_conns[] = { "Port D", "Port B", NULL };
>  static const char *const port_ba_conns[] = { "Port B", "Port A", NULL };
> +static const char *const port_ab_conns[] = { "Port A", "Port B", NULL };
>  static const char *const port_d_conns[] = { "Port D", NULL };
>  
>  static const struct cec_dmi_match cec_dmi_match_table[] = {
> @@ -329,6 +330,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
>  	{ "Google", "Dexi", "0000:00:02.0", port_db_conns },
>  	/* Google Dita */
>  	{ "Google", "Dita", "0000:00:02.0", port_db_conns },
> +	/* Google Dirks */
> +	{ "Google", "Dirks", "0000:00:02.0", port_ab_conns },
>  };
>  
>  static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,