linux-kernel - Re: [PATCH] coresight: replicator: Fix panic for clearing claim tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250506095716.GC177796@e132581.arm.com>
Date: Tue, 6 May 2025 10:57:16 +0100
From: Leo Yan <leo.yan@....com>
To: James Clark <james.clark@...aro.org>
Cc: Suzuki K Poulose <suzuki.poulose@....com>,
	Mike Leach <mike.leach@...aro.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Yeoreum Yun <yeoreum.yun@....com>, coresight@...ts.linaro.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coresight: replicator: Fix panic for clearing claim tag

On Tue, May 06, 2025 at 10:27:37AM +0100, James Clark wrote:

[...]

> > @@ -262,6 +262,7 @@ static int replicator_probe(struct device *dev, struct resource *res)
> >   		drvdata->base = base;
> >   		desc.groups = replicator_groups;
> >   		desc.access = CSDEV_ACCESS_IOMEM(base);
> > +		coresight_clear_self_claim_tag(&desc.access);
> >   	}
> >   	if (fwnode_property_present(dev_fwnode(dev),
> > @@ -284,7 +285,6 @@ static int replicator_probe(struct device *dev, struct resource *res)
> >   	desc.pdata = dev->platform_data;
> >   	desc.dev = dev;
> > -	coresight_clear_self_claim_tag(&desc.access);
> >   	drvdata->csdev = coresight_register(&desc);
> >   	if (IS_ERR(drvdata->csdev)) {
> >   		ret = PTR_ERR(drvdata->csdev);
> 
> Oops. The other occurrence of this is the funnel, but I got that one right.
> 
> Reviewed-by: James Clark <james.clark@...aro.org>

Thanks for review.  Yes, the funnel driver is fine as it accesses claim
tag for only MMIO mode.

Leo