linux-kernel - Re: [PATCH] riscv: dts: sophgo: fix DMA data-width configuration for CV18xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9847f411-c2cc-4543-9f61-1242ff8a0cef@whut.edu.cn>
Date: Tue, 6 May 2025 18:17:53 +0800
From: Ze Huang <huangze@...t.edu.cn>
To: Inochi Amaoto <inochiama@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen Wang <unicorn_wang@...look.com>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>
Cc: devicetree@...r.kernel.org, sophgo@...ts.linux.dev,
 linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Yu Yuan <yu.yuan@...u.edu.cn>, ze huang <huangze@...t.edu.cn>
Subject: Re: [PATCH] riscv: dts: sophgo: fix DMA data-width configuration for
 CV18xx

On 4/30/25 2:54 PM, Inochi Amaoto wrote:
> On Mon, Apr 28, 2025 at 05:24:36PM +0800, Ze Huang wrote:
>> The "snps,data-width" property[1] defines the AXI data width of the DMA
>> controller as:
>>
>>      width = 8 × (2^n) bits
>>
>> (0 = 8 bits, 1 = 16 bits, 2 = 32 bits, ..., 6 = 512 bits)
>> where "n" is the value of "snps,data-width".
>>
>> For the CV18xx DMA controller, the correct AXI data width is 32 bits,
>> corresponding to "snps,data-width = 2".
>>
>> Test results on Milkv Duo S can be found here [2].
>>
>> Link: https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/dma/snps%2Cdw-axi-dmac.yaml#L74 [1]
>> Link: https://gist.github.com/Sutter099/4fa99bb2d89e5af975983124704b3861 [2]
>>
>> Co-developed-by: Yu Yuan <yu.yuan@...u.edu.cn>
>> Signed-off-by: Yu Yuan <yu.yuan@...u.edu.cn>

>> Signed-off-by: Ze Huang <huange@...t.edu.cn>

>> ---
>> Signed-off-by: Ze Huang <huangze@...t.edu.cn>
> I think there is a wrong sob here,

Yeah... There's a typo in mail address.

> also, please add a fixes tag if
> you fix something. I will take care of this when merging.
>
> Fixes: 514951a81a5e ("riscv: dts: sophgo: cv18xx: add DMA controller")
>

Thank you for your review and reminder. I will follow that :-)