linux-kernel - Re: [PATCH v2 2/2] dt-bindings: dma: nvidia,tegra20-apbdma: convert text based binding to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9729fd4-1fed-459a-b242-eabc71503954@gmail.com>
Date: Tue, 6 May 2025 16:16:00 +0530
From: Charan Pedumuru <charan.pedumuru@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>
Cc: dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: dma: nvidia,tegra20-apbdma: convert
 text based binding to json schema



On 06-05-2025 13:00, Krzysztof Kozlowski wrote:
> On 06/05/2025 09:07, Charan Pedumuru wrote:
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
> 
> Why is this a irq.h now?
> 
>> +    #include <dt-bindings/reset/tegra186-reset.h>
>> +    dma-controller@...0a000 {
>> +        compatible = "nvidia,tegra30-apbdma", "nvidia,tegra20-apbdma";
>> +        reg = <0x6000a000 0x1200>;
>> +        interrupts = <0 136 0x04>,
>> +                     <0 137 0x04>,
>> +                     <0 138 0x04>,
>> +                     <0 139 0x04>,
>> +                     <0 140 0x04>,
>> +                     <0 141 0x04>,
>> +                     <0 142 0x04>,
>> +                     <0 143 0x04>,
>> +                     <0 144 0x04>,
>> +                     <0 145 0x04>,
>> +                     <0 146 0x04>,
>> +                     <0 147 0x04>,
>> +                     <0 148 0x04>,
>> +                     <0 149 0x04>,
>> +                     <0 150 0x04>,
>> +                     <0 151 0x04>;
> 
> 
> Again, quoting:
> 
> You included this...
> ... so use it.
> 
> Otherwise what would be the point of including the header?


Yes, I understood it now, will remove the header.


> 
>> +        clocks = <&tegra_car 34>;
>> +        resets = <&tegra_car 34>;
>> +        reset-names = "dma";
>> +        #dma-cells = <1>;
>> +    };
>> +...
>>
> 
> 
> Best regards,
> Krzysztof

-- 
Best Regards,
Charan.