linux-kernel - Re: [PATCH] phy: tegra: xusb: Default otg mode to peripheral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9898a59-2dba-4ffd-a535-893eb989efc8@nvidia.com>
Date: Tue, 6 May 2025 12:09:04 +0100
From: Jon Hunter <jonathanh@...dia.com>
To: webgeek1234@...il.com, JC Kuo <jckuo@...dia.com>,
 Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>,
 Thierry Reding <thierry.reding@...il.com>
Cc: linux-phy@...ts.infradead.org, linux-tegra@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: tegra: xusb: Default otg mode to peripheral



On 04/04/2025 09:17, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@...il.com>
> 
> Currently, if usb-role-switch is set and role-switch-default-mode is
> not, a xusb port will be inoperable until that port is hotplugged,
> because the driver defaults to role none. Instead of requiring all
> devices to set the default mode, assume that the port is primarily
> intended for use in device mode. This assumption already has precedence
> in the synopsys dwc3 driver.
> 
> Signed-off-by: Aaron Kling <webgeek1234@...il.com>
> ---
>   drivers/phy/tegra/xusb.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index 79d4814d758d5e1f0e8200d61e131606adbb0e2d..c56e83216d0f566a09b67377172fb04c8406f4cf 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -731,13 +731,11 @@ static void tegra_xusb_parse_usb_role_default_mode(struct tegra_xusb_port *port)
>   
>   	if (mode == USB_DR_MODE_HOST)
>   		role = USB_ROLE_HOST;
> -	else if (mode == USB_DR_MODE_PERIPHERAL)
> +	else
>   		role = USB_ROLE_DEVICE;

It would be simpler to initialise 'role' as USB_ROLE_DEVICE at the start 
of the function instead of USB_ROLE_NONE. A comment would also be good 
to why this is the default.

Jon

-- 
nvpublic