[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <28757bb3-61b4-423d-850a-70fd5a4c2786@kernel.org>
Date: Tue, 6 May 2025 13:12:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charan Pedumuru <charan.pedumuru@...il.com>, Vinod Koul
<vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>
Cc: dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: dma: nvidia,tegra20-apbdma: convert
text based binding to json schema
On 06/05/2025 13:02, Charan Pedumuru wrote:
> +
> +allOf:
> + - $ref: dma-controller.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/reset/tegra186-reset.h>
> + dma-controller@...0a000 {
> + compatible = "nvidia,tegra30-apbdma", "nvidia,tegra20-apbdma";
> + reg = <0x6000a000 0x1200>;
> + interrupts = <0 136 0x04>,
You gave me little time to respond - 15 minutes - and then you sent v3.
Use the header and its defines instead of hard-coding it. Wasn't this
the entire point why you included the header in the first place in v1?
Otherwise why was it included?
>
Best regards,
Krzysztof
Powered by blists - more mailing lists