linux-kernel - Re: [net-next v10 4/7] net: mtip: The L2 switch driver for imx287

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250506133009.3e945546@wsk>
Date: Tue, 6 May 2025 13:30:09 +0200
From: Lukasz Majewski <lukma@...x.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, davem@...emloft.net, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Richard Cochran
 <richardcochran@...il.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, Stefan Wahren
 <wahrenst@....net>, Simon Horman <horms@...nel.org>, Andrew Lunn
 <andrew@...n.ch>
Subject: Re: [net-next v10 4/7] net: mtip: The L2 switch driver for imx287

Hi Jakub,

> On Sun, 4 May 2025 08:28:11 +0200 Lukasz Majewski wrote:
> > > Now that basic build is green the series has advanced to full
> > > testing, where coccicheck says:
> > > 
> > > drivers/net/ethernet/freescale/mtipsw/mtipl2sw.c:1961:1-6:
> > > WARNING: invalid free of devm_ allocated data
> > > drivers/net/ethernet/freescale/mtipsw/mtipl2sw.c:1237:16-19:
> > > ERROR: bus is NULL but dereferenced.    
> > 
> > I'm sorry for not checking the code with coccinelle.
> > 
> > I do have already used sparse and checkpatch.  
> 
> No worries. Not testing a build W=1 is a bit of a faux pas.

Yes, I'm fully aware of them - mea culpa.

(at least now by default I will have W=1 set :-) )

> But coccinelle is finicky and slow.




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@...x.de

Content of type "application/pgp-signature" skipped