linux-kernel - Re: [PATCH v2 2/2] i2c: i801: don't instantiate spd5118 under SPD Write Disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nfxz37zk2nnqmjwaychfvpl5y5f2stkean2oyxxbk3gzduqvcz@ons6jtbtotuf>
Date: Tue, 6 May 2025 13:53:07 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: "Yo-Jung (Leo) Lin" <leo.lin@...onical.com>
Cc: Jean Delvare <jdelvare@...e.com>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Guenter Roeck <linux@...ck-us.net>, 
	"Chia-Lin Kao (AceLan)" <acelan.kao@...onical.com>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: i801: don't instantiate spd5118 under SPD
 Write Disable

Hi Yo-Jung,

...

> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index a7f89946dad4..88474409e82d 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1177,10 +1177,12 @@ static void i801_probe_optional_targets(struct i801_priv *priv)
>  		dmi_walk(dmi_check_onboard_devices, &priv->adapter);
>  
>  	/* Instantiate SPD EEPROMs unless the SMBus is multiplexed */
> -#ifdef CONFIG_I2C_I801_MUX
> -	if (!priv->mux_pdev)
> -#endif
> -		i2c_register_spd_write_enable(&priv->adapter);
> +	if (!IS_ENABLED(CONFIG_I2C_I801_MUX) || !priv->mux_pdev) {

this if is not really working and it has been reported the
following compile error:

drivers/i2c/busses/i2c-i801.c: In function 'i801_probe_optional_targets':
drivers/i2c/busses/i2c-i801.c:1180:54: error: 'struct i801_priv' has no member named 'mux_pdev'
 1180 |         if (!IS_ENABLED(CONFIG_I2C_I801_MUX) || !priv->mux_pdev) {
      |

Therefore I'm going to revert just this patch 2/2. Please do
resubmit it and please test it properly with the
CONFIG_I2C_I801_MUX enabled and disabled.

Thanks,
Andi